Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322953004: Cast: Don't cancel re-transmission for some cases (Closed)

Created:
6 years, 6 months ago by Alpha Left Google
Modified:
6 years, 6 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, mcasas+watch_chromium.org, mikhal+watch_chromium.org, miu+watch_chromium.org, pwestin+watch_google.com, wjia+watch_chromium.org
Visibility:
Public.

Description

Cast: Don't cancel re-transmission for some cases We were aggresively cancelling re-transmission before. This caused an ill effect with duplicated ACKs that some packets are not transmitted. This change adds a boolean to control whether or not to cancel rtx. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276824

Patch Set 1 #

Total comments: 1

Patch Set 2 : added _if_ #

Patch Set 3 : fixed test #

Patch Set 4 : merged #

Patch Set 5 : merged again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M chrome/browser/media/cast_transport_host_filter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/cast_transport_host_filter.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cast_messages.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/media/cast_transport_sender_ipc.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_transport_sender_ipc.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/transport/cast_transport_sender.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport_sender_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/transport/cast_transport_sender_impl.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (0 generated)
Alpha Left Google
6 years, 6 months ago (2014-06-10 01:33:37 UTC) #1
hubbe
lgtm
6 years, 6 months ago (2014-06-10 16:22:24 UTC) #2
Alpha Left Google
+dcheng for IPC message changes.
6 years, 6 months ago (2014-06-10 18:12:06 UTC) #3
Alpha Left Google
+palmer for IPC changes.
6 years, 6 months ago (2014-06-10 21:54:58 UTC) #4
Alpha Left Google
Ping reviewers. This is an urgent fix.
6 years, 6 months ago (2014-06-11 16:49:13 UTC) #5
Alpha Left Google
+jorgelo for IPC messages review.
6 years, 6 months ago (2014-06-11 16:50:44 UTC) #6
dcheng
cast_messages.h LGTM https://codereview.chromium.org/322953004/diff/1/media/cast/transport/cast_transport_sender.h File media/cast/transport/cast_transport_sender.h (right): https://codereview.chromium.org/322953004/diff/1/media/cast/transport/cast_transport_sender.h#newcode97 media/cast/transport/cast_transport_sender.h:97: // If |cancel_rtx_not_in_list| is used as an ...
6 years, 6 months ago (2014-06-11 17:02:47 UTC) #7
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 17:28:13 UTC) #8
Alpha Left Google
Changed it to cancel_rtx_if_not_in_list. Thanks.
6 years, 6 months ago (2014-06-11 17:28:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/20001
6 years, 6 months ago (2014-06-11 17:32:19 UTC) #10
Alpha Left Google
The CQ bit was unchecked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 18:38:37 UTC) #11
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 18:52:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/40001
6 years, 6 months ago (2014-06-11 18:54:53 UTC) #13
Alpha Left Google
The CQ bit was unchecked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 19:33:41 UTC) #14
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 19:34:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/40001
6 years, 6 months ago (2014-06-11 19:38:12 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:28:07 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:31:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26154) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19641)
6 years, 6 months ago (2014-06-11 21:31:24 UTC) #19
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-11 21:32:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/40001
6 years, 6 months ago (2014-06-11 21:34:29 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:54:05 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:23:01 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/31390) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19717)
6 years, 6 months ago (2014-06-11 22:23:02 UTC) #24
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-12 00:30:24 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/40001
6 years, 6 months ago (2014-06-12 00:31:41 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 02:23:13 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 02:25:24 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/31552) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/28167) win_chromium_rel ...
6 years, 6 months ago (2014-06-12 02:25:26 UTC) #29
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-12 17:30:06 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/40001
6 years, 6 months ago (2014-06-12 17:33:18 UTC) #31
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-06-12 17:41:27 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/322953004/80001
6 years, 6 months ago (2014-06-12 17:44:47 UTC) #33
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:13:14 UTC) #34
Message was sent while issue was closed. 
Change committed as 276824

Powered by Google App Engine
This is Rietveld 408576698