Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 322923002: Pass embedding app identity through at embed time (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M mojo/examples/aura_demo/aura_demo.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 4 chunks +6 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 chunk +10 lines, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-06-10 19:40:52 UTC) #1
sky
LGTM https://codereview.chromium.org/322923002/diff/20001/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc File mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc (right): https://codereview.chromium.org/322923002/diff/20001/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc#newcode712 mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc:712: DCHECK_EQ(kWindowManagerURL, embedded->GetEmbedderURL()); EXPECT_EQ
6 years, 6 months ago (2014-06-10 20:32:51 UTC) #2
Ben Goodger (Google)
6 years, 6 months ago (2014-06-11 15:36:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r276409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698