Issue 322903003: Fix multiple rules generating icudtl.dat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322903003: Fix multiple rules generating icudtl.dat (Closed)

Created:
6 years, 6 months ago by jungshik at Google

Modified:
6 years, 6 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

Fix multiple rules generating icudtl.dat Applying cjhopman's CL [1] to icu 52 BUG=351052, 132145 TEST=For Android build, ninja does not complain about multiple rules generating icudtl.dat TBR=cjhopman@chromium.org [1] https://codereview.chromium.org/317373005/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275893

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -14 lines)			Patch
	M	icu.gyp	View		2 chunks	+26 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

jungshik at Google

I'll TBR this and update the ICU rolling CL (to icu52).

6 years, 6 months ago (2014-06-10 00:36:37 UTC) #1

jungshik at Google

I'll TBR this and update the ICU rolling CL (to icu52).

6 years, 6 months ago (2014-06-10 00:37:59 UTC) #2

jungshik at Google

6 years, 6 months ago (2014-06-10 00:57:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r275893 (presubmit successful).