Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 322893006: Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
Reviewers:
aandrey, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (https://codereview.chromium.org/320933003/) Reason for revert: event-listener-breakpoints.html always timing out on Mac 10.6 (dbg): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg) Original issue's description: > DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. > > This will allow debugger to pause on "load", "error" and etc. event breakpoints only > when they happen on XHR event targets. > > BUG=381470 > R=yurys, pfeldman@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175882 TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=381470 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -147 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/event-listener-breakpoints.html View 3 chunks +2 lines, -57 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/event-listener-breakpoints-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 8 chunks +42 lines, -72 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given ...
6 years, 6 months ago (2014-06-10 18:28:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/322893006/1
6 years, 6 months ago (2014-06-10 18:29:18 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 18:29:42 UTC) #3
Message was sent while issue was closed.
Change committed as 175909

Powered by Google App Engine
This is Rietveld 408576698