Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 322833002: Build fix with gcc 4.8 and C++11 enabled (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Build fix with gcc 4.8 and C++11 enabled Build fix with gcc 4.8 and C++11 enabled. gcc was complaining because it requires 'override' to be specified *before" __attribute__ (WARN_UNUSED_RESULT in this case). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_test_sink.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 6 months ago (2014-06-09 13:43:16 UTC) #1
Inactive
Actual build error: http://pastebin.com/EP7nGsZQ
6 years, 6 months ago (2014-06-09 13:44:05 UTC) #2
jam
lgtm
6 years, 6 months ago (2014-06-09 15:41:44 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-09 15:42:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/322833002/1
6 years, 6 months ago (2014-06-09 15:43:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 13:47:01 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 14:38:45 UTC) #7
Message was sent while issue was closed.
Change committed as 276021

Powered by Google App Engine
This is Rietveld 408576698