Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 32283002: Add test for push-to-trunk script. (Closed)

Created:
7 years, 2 months ago by Michael Achenbach
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add test for push-to-trunk script. This is a prototype attempt for testing the push-to-trunk script. There are several todos left, but it is not clear if it is worth investing time into those. The test is meant to aid in verifying modifications in the push-to-trunk script. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17308

Patch Set 1 #

Total comments: 2

Patch Set 2 : Copyright date. #

Patch Set 3 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -0 lines) Patch
A tools/test-push-to-trunk.sh View 1 2 1 chunk +246 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 2 months ago (2013-10-21 11:48:50 UTC) #1
Jakob Kummerow
LGTM with nits -- pretty much rubberstamped. As discussed offline, I'm fine with landing this, ...
7 years, 2 months ago (2013-10-21 14:58:30 UTC) #2
Michael Achenbach
7 years, 2 months ago (2013-10-22 06:59:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698