Chromium Code Reviews Chromium Code Reviews
Issue
322803004:
Make all CSSSelector data members private (Closed)
DescriptionMake all CSSSelector data members private
Make all CSSSelector data members private. Previously, some of the data members
such as m_relation / m_match / m_pseudoType were public and accessed directly
from outside the class. The new approach is better because:
- Those members are bit fields so by using getters, we can hide the casts inside
the getters. The setters can now also check that the bitfield is big enough to
actually store the enum value.
- When using those in switch() statements, the compiler now complains if we fail
to test some of the enum values as the value is now an enum, and not merely an
unsigned integer.
- Some of these members already has getters (e.g. relation(), pseudoType()).
- Better encapsulation.
R=esprehn@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175994
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Fix win dbg build error #
Total comments: 1
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
