Issue 322793003: Devtools: Move out helper methods from breakpoint-manager.html to separate file to reuse them later

Issue 322793003: Devtools: Move out helper methods from breakpoint-manager.html to separate file to reuse them later (Closed)

Created:
6 years, 6 months ago by sergeyv

Modified:
6 years, 6 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Devtools: Move out helper methods from breakpoint-manager.html to separate file to reuse them later BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175879

Patch Set 1 #

Patch Set 2 : Add callback to InspectorTest.setBreakpoint #

Total comments: 5

Patch Set 3 : Move methods used in one test to that test #

Patch Set 4 : Address vsevik's comments #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+401 lines, -527 lines)			Patch
	M	LayoutTests/inspector/sources/debugger/breakpoint-manager.html	View	1 2 3	17 chunks	+93 lines, -527 lines	0 comments	Download
	A	LayoutTests/inspector/sources/debugger/breakpoint-manager.js	View	1 2 3	1 chunk	+308 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/322793003/diff/20001/LayoutTests/inspector/sources/debugger/breakpoint-manager.html File LayoutTests/inspector/sources/debugger/breakpoint-manager.html (right): https://codereview.chromium.org/322793003/diff/20001/LayoutTests/inspector/sources/debugger/breakpoint-manager.html#newcode174 LayoutTests/inspector/sources/debugger/breakpoint-manager.html:174: InspectorTest.setBreakpoint(breakpointManager, uiSourceCode, 1015, 0, "", true, InspectorTest.resetAndFinish.bind(this, breakpointManager, ...

6 years, 6 months ago (2014-06-09 15:27:11 UTC) #2

sergeyv

https://codereview.chromium.org/322793003/diff/20001/LayoutTests/inspector/sources/debugger/breakpoint-manager.html File LayoutTests/inspector/sources/debugger/breakpoint-manager.html (right): https://codereview.chromium.org/322793003/diff/20001/LayoutTests/inspector/sources/debugger/breakpoint-manager.html#newcode350 LayoutTests/inspector/sources/debugger/breakpoint-manager.html:350: window.setBreakpointCallback = InspectorTest.resetAndFinish.bind(this, breakpointManager, next); On 2014/06/09 15:27:11, vsevik ...

6 years, 6 months ago (2014-06-10 08:56:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/322793003/60001

6 years, 6 months ago (2014-06-10 08:57:12 UTC) #5

Message was sent while issue was closed.

Change committed as 175879

Expand Messages | Collapse Messages