Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: Source/devtools/front_end/timeline/TracingModel.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.TargetAwareObject} 9 * @extends {WebInspector.TargetAwareObject}
10 */ 10 */
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 this._active = false; 161 this._active = false;
162 if (!this._pendingStopCallback) 162 if (!this._pendingStopCallback)
163 return; 163 return;
164 this._pendingStopCallback(); 164 this._pendingStopCallback();
165 this._pendingStopCallback = null; 165 this._pendingStopCallback = null;
166 }, 166 },
167 167
168 reset: function() 168 reset: function()
169 { 169 {
170 this._processById = {}; 170 this._processById = {};
171 this._minimumRecordTime = null; 171 this._minimumRecordTime = 0;
172 this._maximumRecordTime = null; 172 this._maximumRecordTime = 0;
173 this._sessionId = null; 173 this._sessionId = null;
174 this._devtoolsMetadataEvents = []; 174 this._devtoolsMetadataEvents = [];
175 }, 175 },
176 176
177 /** 177 /**
178 * @param {!WebInspector.TracingModel.EventPayload} payload 178 * @param {!WebInspector.TracingModel.EventPayload} payload
179 */ 179 */
180 _addEvent: function(payload) 180 _addEvent: function(payload)
181 { 181 {
182 var process = this._processById[payload.pid]; 182 var process = this._processById[payload.pid];
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 case WebInspector.TracingModel.MetadataEvent.ThreadSortIndex: 215 case WebInspector.TracingModel.MetadataEvent.ThreadSortIndex:
216 thread._setSortIndex(payload.args["sort_index"]); 216 thread._setSortIndex(payload.args["sort_index"]);
217 break; 217 break;
218 case WebInspector.TracingModel.MetadataEvent.ThreadName: 218 case WebInspector.TracingModel.MetadataEvent.ThreadName:
219 thread._setName(payload.args["name"]); 219 thread._setName(payload.args["name"]);
220 break; 220 break;
221 } 221 }
222 }, 222 },
223 223
224 /** 224 /**
225 * @return {?number} 225 * @return {number}
226 */ 226 */
227 minimumRecordTime: function() 227 minimumRecordTime: function()
228 { 228 {
229 return this._minimumRecordTime; 229 return this._minimumRecordTime;
230 }, 230 },
231 231
232 /** 232 /**
233 * @return {?number} 233 * @return {number}
234 */ 234 */
235 maximumRecordTime: function() 235 maximumRecordTime: function()
236 { 236 {
237 return this._maximumRecordTime; 237 return this._maximumRecordTime;
238 }, 238 },
239 239
240 /** 240 /**
241 * @return {!Array.<!WebInspector.TracingModel.Process>} 241 * @return {!Array.<!WebInspector.TracingModel.Process>}
242 */ 242 */
243 sortedProcesses: function() 243 sortedProcesses: function()
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 dataCollected: function(data) 552 dataCollected: function(data)
553 { 553 {
554 this._tracingModel._eventsCollected(data); 554 this._tracingModel._eventsCollected(data);
555 }, 555 },
556 556
557 tracingComplete: function() 557 tracingComplete: function()
558 { 558 {
559 this._tracingModel._tracingComplete(); 559 this._tracingModel._tracingComplete();
560 } 560 }
561 } 561 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | Source/devtools/front_end/timeline/TracingTimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698