Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineTracingView.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @implements {WebInspector.TimelineModeView} 9 * @implements {WebInspector.TimelineModeView}
10 * @implements {WebInspector.FlameChartDelegate} 10 * @implements {WebInspector.FlameChartDelegate}
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 */ 309 */
310 this._timelineData = { 310 this._timelineData = {
311 entryLevels: [], 311 entryLevels: [],
312 entryTotalTimes: [], 312 entryTotalTimes: [],
313 entryStartTimes: [] 313 entryStartTimes: []
314 }; 314 };
315 315
316 this._currentLevel = 0; 316 this._currentLevel = 0;
317 this._headerTitles = {}; 317 this._headerTitles = {};
318 this._minimumBoundary = this._timelineModelForMinimumBoundary.minimumRec ordTime(); 318 this._minimumBoundary = this._timelineModelForMinimumBoundary.minimumRec ordTime();
319 this._timeSpan = Math.max((this._model.maximumRecordTime() || 0) - this. _minimumBoundary, 1000); 319 this._timeSpan = Math.max(this._model.maximumRecordTime() - this._minimu mBoundary, 1000);
320 var processes = this._model.sortedProcesses(); 320 var processes = this._model.sortedProcesses();
321 for (var processIndex = 0; processIndex < processes.length; ++processInd ex) { 321 for (var processIndex = 0; processIndex < processes.length; ++processInd ex) {
322 var process = processes[processIndex]; 322 var process = processes[processIndex];
323 this._appendHeaderRecord(process.name(), this._processHeaderRecord); 323 this._appendHeaderRecord(process.name(), this._processHeaderRecord);
324 var objectNames = process.sortedObjectNames(); 324 var objectNames = process.sortedObjectNames();
325 for (var objectNameIndex = 0; objectNameIndex < objectNames.length; ++objectNameIndex) { 325 for (var objectNameIndex = 0; objectNameIndex < objectNames.length; ++objectNameIndex) {
326 this._appendHeaderRecord(WebInspector.UIString("Object %s", obje ctNames[objectNameIndex]), this._threadHeaderRecord); 326 this._appendHeaderRecord(WebInspector.UIString("Object %s", obje ctNames[objectNameIndex]), this._threadHeaderRecord);
327 var objects = process.objectsByName(objectNames[objectNameIndex] ); 327 var objects = process.objectsByName(objectNames[objectNameIndex] );
328 for (var objectIndex = 0; objectIndex < objects.length; ++object Index) 328 for (var objectIndex = 0; objectIndex < objects.length; ++object Index)
329 this._appendRecord(objects[objectIndex]); 329 this._appendRecord(objects[objectIndex]);
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 /** 573 /**
574 * @param {string} string 574 * @param {string} string
575 * @return {string} 575 * @return {string}
576 */ 576 */
577 colorForString: function(string) 577 colorForString: function(string)
578 { 578 {
579 var hash = WebInspector.TraceViewPalette._stringHash(string); 579 var hash = WebInspector.TraceViewPalette._stringHash(string);
580 return this._palette[hash % this._palette.length]; 580 return this._palette[hash % this._palette.length];
581 } 581 }
582 }; 582 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698