Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 this._detailsView.setVertical(vertically); 195 this._detailsView.setVertical(vertically);
196 }, 196 },
197 197
198 /** 198 /**
199 * @return {number} 199 * @return {number}
200 */ 200 */
201 windowStartTime: function() 201 windowStartTime: function()
202 { 202 {
203 if (this._windowStartTime) 203 if (this._windowStartTime)
204 return this._windowStartTime; 204 return this._windowStartTime;
205 var minimumRecordTime = this._model.minimumRecordTime(); 205 return this._model.minimumRecordTime();
206 if (minimumRecordTime && minimumRecordTime !== -1)
207 return minimumRecordTime;
208 return 0;
209 }, 206 },
210 207
211 /** 208 /**
212 * @return {number} 209 * @return {number}
213 */ 210 */
214 windowEndTime: function() 211 windowEndTime: function()
215 { 212 {
216 if (this._windowEndTime < Infinity) 213 if (this._windowEndTime < Infinity)
217 return this._windowEndTime; 214 return this._windowEndTime;
218 var maximumRecordTime = this._model.maximumRecordTime(); 215 return this._model.maximumRecordTime() || Infinity;
219 if (maximumRecordTime && maximumRecordTime !== -1)
220 return maximumRecordTime;
221 return Infinity;
222 }, 216 },
223 217
224 /** 218 /**
225 * @param {!WebInspector.Event} event 219 * @param {!WebInspector.Event} event
226 */ 220 */
227 _sidebarResized: function(event) 221 _sidebarResized: function(event)
228 { 222 {
229 var width = /** @type {number} */ (event.data); 223 var width = /** @type {number} */ (event.data);
230 this._topPane.setSidebarSize(width); 224 this._topPane.setSidebarSize(width);
231 for (var i = 0; i < this._currentViews.length; ++i) 225 for (var i = 0; i < this._currentViews.length; ++i)
(...skipping 1190 matching lines...) Expand 10 before | Expand all | Expand 10 after
1422 * @param {!WebInspector.TimelineModel.Record} record 1416 * @param {!WebInspector.TimelineModel.Record} record
1423 * @return {boolean} 1417 * @return {boolean}
1424 */ 1418 */
1425 accept: function(record) 1419 accept: function(record)
1426 { 1420 {
1427 return !this._hiddenRecords[record.type()]; 1421 return !this._hiddenRecords[record.type()];
1428 }, 1422 },
1429 1423
1430 __proto__: WebInspector.TimelineModel.Filter.prototype 1424 __proto__: WebInspector.TimelineModel.Filter.prototype
1431 } 1425 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineOverviewPane.js ('k') | Source/devtools/front_end/timeline/TimelineTracingView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698