Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: Source/devtools/front_end/timeline/TracingModel.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @constructor 8 * @constructor
9 * @extends {WebInspector.TargetAwareObject} 9 * @extends {WebInspector.TargetAwareObject}
10 */ 10 */
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 this._active = false; 157 this._active = false;
158 if (!this._pendingStopCallback) 158 if (!this._pendingStopCallback)
159 return; 159 return;
160 this._pendingStopCallback(); 160 this._pendingStopCallback();
161 this._pendingStopCallback = null; 161 this._pendingStopCallback = null;
162 }, 162 },
163 163
164 reset: function() 164 reset: function()
165 { 165 {
166 this._processById = {}; 166 this._processById = {};
167 this._minimumRecordTime = null; 167 this._minimumRecordTime = 0;
168 this._maximumRecordTime = null; 168 this._maximumRecordTime = 0;
169 this._sessionId = null; 169 this._sessionId = null;
170 this._devtoolsMetadataEvents = []; 170 this._devtoolsMetadataEvents = [];
171 }, 171 },
172 172
173 /** 173 /**
174 * @param {!WebInspector.TracingModel.EventPayload} payload 174 * @param {!WebInspector.TracingModel.EventPayload} payload
175 */ 175 */
176 _addEvent: function(payload) 176 _addEvent: function(payload)
177 { 177 {
178 var process = this._processById[payload.pid]; 178 var process = this._processById[payload.pid];
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 case WebInspector.TracingModel.MetadataEvent.ThreadSortIndex: 211 case WebInspector.TracingModel.MetadataEvent.ThreadSortIndex:
212 thread._setSortIndex(payload.args["sort_index"]); 212 thread._setSortIndex(payload.args["sort_index"]);
213 break; 213 break;
214 case WebInspector.TracingModel.MetadataEvent.ThreadName: 214 case WebInspector.TracingModel.MetadataEvent.ThreadName:
215 thread._setName(payload.args["name"]); 215 thread._setName(payload.args["name"]);
216 break; 216 break;
217 } 217 }
218 }, 218 },
219 219
220 /** 220 /**
221 * @return {?number} 221 * @return {number}
222 */ 222 */
223 minimumRecordTime: function() 223 minimumRecordTime: function()
224 { 224 {
225 return this._minimumRecordTime; 225 return this._minimumRecordTime;
226 }, 226 },
227 227
228 /** 228 /**
229 * @return {?number} 229 * @return {number}
230 */ 230 */
231 maximumRecordTime: function() 231 maximumRecordTime: function()
232 { 232 {
233 return this._maximumRecordTime; 233 return this._maximumRecordTime;
234 }, 234 },
235 235
236 /** 236 /**
237 * @return {!Array.<!WebInspector.TracingModel.Process>} 237 * @return {!Array.<!WebInspector.TracingModel.Process>}
238 */ 238 */
239 sortedProcesses: function() 239 sortedProcesses: function()
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 dataCollected: function(data) 548 dataCollected: function(data)
549 { 549 {
550 this._tracingModel._eventsCollected(data); 550 this._tracingModel._eventsCollected(data);
551 }, 551 },
552 552
553 tracingComplete: function() 553 tracingComplete: function()
554 { 554 {
555 this._tracingModel._tracingComplete(); 555 this._tracingModel._tracingComplete();
556 } 556 }
557 } 557 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698