Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 322783002: Initialize min/max record time to 0 instead of -1 or null (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 this._detailsView.setVertical(vertically); 197 this._detailsView.setVertical(vertically);
198 }, 198 },
199 199
200 /** 200 /**
201 * @return {number} 201 * @return {number}
202 */ 202 */
203 windowStartTime: function() 203 windowStartTime: function()
204 { 204 {
205 if (this._windowStartTime) 205 if (this._windowStartTime)
206 return this._windowStartTime; 206 return this._windowStartTime;
207 var minimumRecordTime = this._model.minimumRecordTime(); 207 return this._model.minimumRecordTime();
208 if (minimumRecordTime && minimumRecordTime != -1)
209 return minimumRecordTime;
210 return 0;
211 }, 208 },
212 209
213 /** 210 /**
214 * @return {number} 211 * @return {number}
215 */ 212 */
216 windowEndTime: function() 213 windowEndTime: function()
217 { 214 {
218 if (this._windowEndTime < Infinity) 215 if (this._windowEndTime < Infinity)
219 return this._windowEndTime; 216 return this._windowEndTime;
220 var maximumRecordTime = this._model.maximumRecordTime(); 217 return this._model.maximumRecordTime() || Infinity;
221 if (maximumRecordTime && maximumRecordTime != -1)
222 return maximumRecordTime;
223 return Infinity;
224 }, 218 },
225 219
226 /** 220 /**
227 * @param {!WebInspector.Event} event 221 * @param {!WebInspector.Event} event
228 */ 222 */
229 _sidebarResized: function(event) 223 _sidebarResized: function(event)
230 { 224 {
231 var width = /** @type {number} */ (event.data); 225 var width = /** @type {number} */ (event.data);
232 this._topPane.setSidebarSize(width); 226 this._topPane.setSidebarSize(width);
233 for (var i = 0; i < this._currentViews.length; ++i) 227 for (var i = 0; i < this._currentViews.length; ++i)
(...skipping 1192 matching lines...) Expand 10 before | Expand all | Expand 10 after
1426 * @param {!WebInspector.TimelineModel.Record} record 1420 * @param {!WebInspector.TimelineModel.Record} record
1427 * @return {boolean} 1421 * @return {boolean}
1428 */ 1422 */
1429 accept: function(record) 1423 accept: function(record)
1430 { 1424 {
1431 return !this._hiddenRecords[record.type()]; 1425 return !this._hiddenRecords[record.type()];
1432 }, 1426 },
1433 1427
1434 __proto__: WebInspector.TimelineModel.Filter.prototype 1428 __proto__: WebInspector.TimelineModel.Filter.prototype
1435 } 1429 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698