Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322763002: Timeline: fix trace event nesting computation after r175746 (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: fix trace event nesting computation after r175746 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175791

Patch Set 1 #

Patch Set 2 : compute endTime & duration with better precision #

Total comments: 1

Patch Set 3 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/devtools/front_end/timeline/TracingModel.js View 1 2 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
caseq
6 years, 6 months ago (2014-06-09 07:18:47 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-09 07:19:51 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 07:20:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/322763002/1
6 years, 6 months ago (2014-06-09 07:21:57 UTC) #4
caseq
The CQ bit was unchecked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 07:35:55 UTC) #5
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 11:31:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/322763002/20001
6 years, 6 months ago (2014-06-09 11:31:45 UTC) #7
yurys
https://codereview.chromium.org/322763002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js File Source/devtools/front_end/timeline/TracingModel.js (right): https://codereview.chromium.org/322763002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js#newcode268 Source/devtools/front_end/timeline/TracingModel.js:268: this.duration = payload.dur / 1000; I'd probably write it ...
6 years, 6 months ago (2014-06-09 11:38:47 UTC) #8
caseq
The CQ bit was unchecked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 11:39:47 UTC) #9
caseq
On 2014/06/09 11:38:47, yurys wrote: > https://codereview.chromium.org/322763002/diff/20001/Source/devtools/front_end/timeline/TracingModel.js#newcode268 > Source/devtools/front_end/timeline/TracingModel.js:268: this.duration = > payload.dur / 1000; ...
6 years, 6 months ago (2014-06-09 11:47:34 UTC) #10
yurys
Patch set #3 lgtm
6 years, 6 months ago (2014-06-09 11:51:29 UTC) #11
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 11:53:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/322763002/40001
6 years, 6 months ago (2014-06-09 11:53:51 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 12:56:35 UTC) #14
Message was sent while issue was closed. 
Change committed as 175791

Powered by Google App Engine
This is Rietveld 408576698