Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 322753002: Enabling WebRTC browser tests that used to be flaky under TSAN or Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/threading/platform_thread.h" 8 #include "base/threading/platform_thread.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "content/browser/media/webrtc_internals.h" 10 #include "content/browser/media/webrtc_internals.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 // Flaky on TSAN v2. http://crbug.com/373637 162 // Flaky on TSAN v2. http://crbug.com/373637
163 #if defined(THREAD_SANITIZER) 163 #if defined(THREAD_SANITIZER)
164 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p 164 #define MAYBE_CanForwardRemoteStream720p DISABLED_CanForwardRemoteStream720p
165 #else 165 #else
166 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p 166 #define MAYBE_CanForwardRemoteStream720p CanForwardRemoteStream720p
167 #endif 167 #endif
168 #endif 168 #endif
169 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) { 169 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanForwardRemoteStream) {
170 #if defined (OS_ANDROID) 170 #if defined (OS_ANDROID)
171 // This test fails on Nexus 5 devices. 171 // This test fails on Nexus 5 devices.
172 // TODO: see http://crbug.com/362437 and http://crbug.com/359389 172 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389
173 // for details. 173 // for details.
174 CommandLine::ForCurrentProcess()->AppendSwitch( 174 CommandLine::ForCurrentProcess()->AppendSwitch(
175 switches::kDisableWebRtcHWDecoding); 175 switches::kDisableWebRtcHWDecoding);
176 #endif 176 #endif
177 MakeTypicalPeerConnectionCall( 177 MakeTypicalPeerConnectionCall(
178 "callAndForwardRemoteStream({video: true, audio: false});"); 178 "callAndForwardRemoteStream({video: true, audio: false});");
179 } 179 }
180 180
181 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanForwardRemoteStream720p) { 181 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanForwardRemoteStream720p) {
182 #if defined (OS_ANDROID) 182 #if defined (OS_ANDROID)
183 // This test fails on Nexus 5 devices. 183 // This test fails on Nexus 5 devices.
184 // TODO: see http://crbug.com/362437 and http://crbug.com/359389 184 // TODO(henrika): see http://crbug.com/362437 and http://crbug.com/359389
185 // for details. 185 // for details.
186 CommandLine::ForCurrentProcess()->AppendSwitch( 186 CommandLine::ForCurrentProcess()->AppendSwitch(
187 switches::kDisableWebRtcHWDecoding); 187 switches::kDisableWebRtcHWDecoding);
188 #endif 188 #endif
189 const std::string javascript = GenerateGetUserMediaCall( 189 const std::string javascript = GenerateGetUserMediaCall(
190 "callAndForwardRemoteStream", 1280, 1280, 720, 720, 10, 30); 190 "callAndForwardRemoteStream", 1280, 1280, 720, 720, 10, 30);
191 MakeTypicalPeerConnectionCall(javascript); 191 MakeTypicalPeerConnectionCall(javascript);
192 } 192 }
193 193
194 // This test will make a complete PeerConnection-based call but remove the 194 // This test will make a complete PeerConnection-based call but remove the
(...skipping 29 matching lines...) Expand all
224 // the bandwidth for audio and video 224 // the bandwidth for audio and video
225 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, NegotiateOfferWithBLine) { 225 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, NegotiateOfferWithBLine) {
226 MakeTypicalPeerConnectionCall("negotiateOfferWithBLine();"); 226 MakeTypicalPeerConnectionCall("negotiateOfferWithBLine();");
227 } 227 }
228 228
229 // This test will make a complete PeerConnection-based call using legacy SDP 229 // This test will make a complete PeerConnection-based call using legacy SDP
230 // settings: GIce, external SDES, and no BUNDLE. 230 // settings: GIce, external SDES, and no BUNDLE.
231 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY) 231 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
232 // Timing out on ARM linux, see http://crbug.com/240373 232 // Timing out on ARM linux, see http://crbug.com/240373
233 #define MAYBE_CanSetupLegacyCall DISABLED_CanSetupLegacyCall 233 #define MAYBE_CanSetupLegacyCall DISABLED_CanSetupLegacyCall
234 #elif defined (OS_ANDROID) || defined(THREAD_SANITIZER)
235 // Flaky on TSAN v2 and Android Tests (dbg): http://crbug.com/373637
236 #define MAYBE_CanSetupLegacyCall DISABLED_CanSetupLegacyCall
237 #else 234 #else
238 #define MAYBE_CanSetupLegacyCall CanSetupLegacyCall 235 #define MAYBE_CanSetupLegacyCall CanSetupLegacyCall
239 #endif 236 #endif
240 237
241 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanSetupLegacyCall) { 238 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CanSetupLegacyCall) {
242 MakeTypicalPeerConnectionCall("callWithLegacySdp();"); 239 MakeTypicalPeerConnectionCall("callWithLegacySdp();");
243 } 240 }
244 241
245 // This test will make a PeerConnection-based call and test an unreliable text 242 // This test will make a PeerConnection-based call and test an unreliable text
246 // dataChannel. 243 // dataChannel.
247 // TODO(mallinath) - Remove this test after rtp based data channel is disabled. 244 // TODO(mallinath) - Remove this test after rtp based data channel is disabled.
248 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, CallWithDataOnly) { 245 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, CallWithDataOnly) {
249 MakeTypicalPeerConnectionCall("callWithDataOnly();"); 246 MakeTypicalPeerConnectionCall("callWithDataOnly();");
250 } 247 }
251 248
252 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, CallWithSctpDataOnly) { 249 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, CallWithSctpDataOnly) {
253 MakeTypicalPeerConnectionCall("callWithSctpDataOnly();"); 250 MakeTypicalPeerConnectionCall("callWithSctpDataOnly();");
254 } 251 }
255 252
256 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY) 253 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
257 // Timing out on ARM linux bot: http://crbug.com/238490 254 // Timing out on ARM linux bot: http://crbug.com/238490
258 #define MAYBE_CallWithDataAndMedia DISABLED_CallWithDataAndMedia 255 #define MAYBE_CallWithDataAndMedia DISABLED_CallWithDataAndMedia
259 #elif defined(THREAD_SANITIZER)
260 // Flaky on TSAN v2: http://crbug.com/373637
261 #define MAYBE_CallWithDataAndMedia DISABLED_CallWithDataAndMedia
262 #else 256 #else
263 #define MAYBE_CallWithDataAndMedia CallWithDataAndMedia 257 #define MAYBE_CallWithDataAndMedia CallWithDataAndMedia
264 #endif 258 #endif
265 259
266 // This test will make a PeerConnection-based call and test an unreliable text 260 // This test will make a PeerConnection-based call and test an unreliable text
267 // dataChannel and audio and video tracks. 261 // dataChannel and audio and video tracks.
268 // TODO(mallinath) - Remove this test after rtp based data channel is disabled. 262 // TODO(mallinath) - Remove this test after rtp based data channel is disabled.
269 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, DISABLED_CallWithDataAndMedia) { 263 IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, DISABLED_CallWithDataAndMedia) {
270 MakeTypicalPeerConnectionCall("callWithDataAndMedia();"); 264 MakeTypicalPeerConnectionCall("callWithDataAndMedia();");
271 } 265 }
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 456
463 EXPECT_TRUE(base::PathExists(dump_file)); 457 EXPECT_TRUE(base::PathExists(dump_file));
464 int64 file_size = 0; 458 int64 file_size = 0;
465 EXPECT_TRUE(base::GetFileSize(dump_file, &file_size)); 459 EXPECT_TRUE(base::GetFileSize(dump_file, &file_size));
466 EXPECT_EQ(0, file_size); 460 EXPECT_EQ(0, file_size);
467 461
468 base::DeleteFile(dump_file, false); 462 base::DeleteFile(dump_file, false);
469 } 463 }
470 464
471 } // namespace content 465 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698