Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 322713002: test_runner: Migrate WebPermissions to our Chromium C++ style. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jochen (gone - plz use gerrit), jam, darin (slow to review)
Visibility:
Public.

Description

test_runner: Migrate WebPermissions to our Chromium C++ style. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 2) Rename methods to use CamelCase style. 3) Rename file name to web_permissions. BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277981

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix rebase error #

Patch Set 4 : more rebase fixes #

Patch Set 5 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -324 lines) Patch
M content/content_shell.gypi View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/WebPermissions.h View 1 1 chunk +0 lines, -62 lines 0 comments Download
D content/shell/renderer/test_runner/WebPermissions.cpp View 1 1 chunk +0 lines, -127 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
A + content/shell/renderer/test_runner/web_permissions.h View 1 2 3 4 2 chunks +50 lines, -45 lines 0 comments Download
A + content/shell/renderer/test_runner/web_permissions.cc View 1 2 3 4 1 chunk +71 lines, -77 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tfarina
TBRing...(please, rubber stamp).
6 years, 6 months ago (2014-06-08 05:51:42 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-09 17:14:07 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-14 17:02:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/322713002/20001
6 years, 6 months ago (2014-06-14 17:02:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 17:30:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/22609)
6 years, 6 months ago (2014-06-14 17:30:05 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-14 18:14:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/322713002/40001
6 years, 6 months ago (2014-06-14 18:15:06 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-14 23:06:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/322713002/60001
6 years, 6 months ago (2014-06-14 23:06:29 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-15 04:47:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/152193)
6 years, 6 months ago (2014-06-15 04:47:39 UTC) #12
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-17 21:41:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/322713002/100001
6 years, 6 months ago (2014-06-17 21:43:10 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 08:24:12 UTC) #15
Message was sent while issue was closed.
Change committed as 277981

Powered by Google App Engine
This is Rietveld 408576698