Issue 32263002: Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type feedback wa…

Issue 32263002: Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type feedback wa… (Closed)

Created:
7 years, 2 months ago by Hannes Payer (out of office)

Modified:
7 years, 2 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type feedback was collected. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17288

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -8 lines)			Patch
M	src/ast.h	View	1 2	5 chunks	+11 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1	3 chunks	+8 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/type-info.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/type-info.cc	View		3 chunks	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danno

https://codereview.chromium.org/32263002/diff/30001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/32263002/diff/30001/src/hydrogen.cc#newcode5796 src/hydrogen.cc:5796: (expr->AsAssignment()->IsUninitialized() || Could you turn the check for both ...

7 years, 2 months ago (2013-10-21 11:51:39 UTC) #2

Hannes Payer (out of office)

7 years, 2 months ago (2013-10-21 12:06:54 UTC) #3

Hannes Payer (out of office)

7 years, 2 months ago (2013-10-21 12:10:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r17288 (presubmit successful).

Expand Messages | Collapse Messages