Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322623002: Consolidate SDK forwards in sdk_forward_declarations.h. (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, James Su, yusukes+watch_chromium.org, tommycli, benjhayden+dwatch_chromium.org, tfarina, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, jam, Lei Zhang, darin-cc_chromium.org, Greg Billock, vandebo (ex-Chrome), chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, nona+watch_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Consolidate SDK forwards in sdk_forward_declarations.h. BUG=none TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275578

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -345 lines) Patch
M apps/app_shim/chrome_main_app_mode_mac.mm View 2 chunks +1 line, -10 lines 0 comments Download
M base/mac/mac_util.mm View 2 chunks +1 line, -10 lines 0 comments Download
M base/mac/sdk_forward_declarations.h View 1 6 chunks +151 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_status_updater_mac.mm View 1 chunk +1 line, -37 lines 0 comments Download
M chrome/browser/fullscreen_mac.mm View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 2 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 2 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/nsview_additions.mm View 2 chunks +1 line, -21 lines 0 comments Download
M components/storage_monitor/image_capture_device_manager_unittest.mm View 2 chunks +1 line, -13 lines 0 comments Download
M components/wifi/wifi_service_mac.mm View 1 chunk +1 line, -29 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +1 line, -19 lines 0 comments Download
M content/browser/theme_helper_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/cursors/webcursor_mac.mm View 2 chunks +1 line, -10 lines 0 comments Download
M content/shell/browser/shell_mac.mm View 2 chunks +1 line, -10 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 2 chunks +1 line, -20 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 2 chunks +1 line, -14 lines 0 comments Download
M device/bluetooth/bluetooth_profile_mac.mm View 2 chunks +1 line, -10 lines 0 comments Download
M ui/app_list/cocoa/scroll_view_with_no_scrollbars.mm View 1 chunk +1 line, -22 lines 0 comments Download
M ui/message_center/cocoa/popup_controller.mm View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
6 years, 6 months ago (2014-06-06 20:42:06 UTC) #1
Mark Mentovai
LGTM, spot-check + rubber-stamp. https://codereview.chromium.org/322623002/diff/1/base/mac/sdk_forward_declarations.h File base/mac/sdk_forward_declarations.h (right): https://codereview.chromium.org/322623002/diff/1/base/mac/sdk_forward_declarations.h#newcode229 base/mac/sdk_forward_declarations.h:229: // Flatten all child views ...
6 years, 6 months ago (2014-06-06 21:09:03 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/322623002/diff/1/base/mac/sdk_forward_declarations.h File base/mac/sdk_forward_declarations.h (right): https://codereview.chromium.org/322623002/diff/1/base/mac/sdk_forward_declarations.h#newcode229 base/mac/sdk_forward_declarations.h:229: // Flatten all child views that did not call ...
6 years, 6 months ago (2014-06-06 21:13:10 UTC) #3
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 6 months ago (2014-06-06 21:14:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/322623002/20001
6 years, 6 months ago (2014-06-06 21:15:33 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:59:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 275578

Powered by Google App Engine
This is Rietveld 408576698