Detecting form locale

chrome/renderer/form_manager_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/renderer/form_manager.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
@@ skipping 14 matching lines @@
 using WebKit::WebInputElement;
 using WebKit::WebNode;
 using WebKit::WebString;
 using WebKit::WebVector;
 
 using webkit_glue::FormData;
 using webkit_glue::FormField;
 
 namespace {
 
-typedef RenderViewTest FormManagerTest;
+class FormManagerTest : public RenderViewTest {
+ public:
+  // Load a single form from an HTML snippet.
+  void LoadForm(const char* const html, FormData *form);
+
+  // Test that we have extracted the default form data (disregarding the form
+  // fields).
+  void ExpectDefaultForm(const FormData& form);
+
+  // Test that the form loaded from |html| has locale |locale|.
+  void ExpectLocale(const char* const locale, const char* const html);
+};
+
+void FormManagerTest::LoadForm(const char* const html, FormData *form) {
+  LoadHTML(html);
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  FormManager form_manager;
+  form_manager.ExtractForms(web_frame);
+
+  std::vector<FormData> forms;
+  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
+  ASSERT_EQ(1U, forms.size());
+
+  *form = forms[0];
+  EXPECT_EQ(GURL(web_frame->url()), form->origin);
+}
+
+void FormManagerTest::ExpectDefaultForm(const FormData& form) {
+  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
+  EXPECT_EQ(ASCIIToUTF16("post"), form.method);
+  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  EXPECT_EQ(std::string(), form.locale);
+}
+
+void FormManagerTest::ExpectLocale(const char* const locale,
+                                   const char* const html) {
+  FormData form;
+  LoadForm(html, &form);
+  EXPECT_EQ(locale, form.locale);
+}
 
 TEST_F(FormManagerTest, WebFormElementToFormData) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            "  <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"hidden\" id=\"notvisible\" value=\"apple\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
            "</FORM>");
 
   WebFrame* frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
 
   WebVector<WebFormElement> forms;
   frame->forms(forms);
   ASSERT_EQ(1U, forms.size());
 
   FormData form;
   EXPECT_TRUE(FormManager::WebFormElementToFormData(forms[0],
                                                     FormManager::REQUIRE_NONE,
                                                     true,
                                                     &form));
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(4U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("John"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("lastname"),
                 ASCIIToUTF16("Smith"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("notvisible"),
                 ASCIIToUTF16("apple"),
                 ASCIIToUTF16("hidden"),
                 0)));
   EXPECT_TRUE(fields[3].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
+// Ensure that form locales are correctly determined from the DOM.
+// We are essentially duplicating a WebKit layout test here, but better safe
+// than sorry.
+TEST_F(FormManagerTest, FormLocale) {
+  // Test the default behavior, when no locale is specified.
+  ExpectLocale("",
+               "<FORM>"
+               "  <INPUT type=\"text\" value=\"dummy\"/>"
+               "</FORM>");
+
+  // Test that we correctly detect the locale when it is directly specified.
+  ExpectLocale("fr-CA",
+               "<FORM lang=\"fr-CA\">"
+               "  <INPUT type=\"text\" value=\"dummy\"/>"
+               "</FORM>");
+
+  // Test that the locale is properly inherited.
+  ExpectLocale("en-GB",
+               "<DIV lang=\"en-GB\">"
+               "  <FORM>"
+               "    <INPUT type=\"text\" value=\"dummy\"/>"
+               "  </FORM>"
+               "</DIV>");
+
+  // Test that inheritance stops properly.
+  ExpectLocale("en-US",
+               "<DIV lang=\"en-GB\">"
+               "  <FORM lang=\"en-US\">"
+               "    <INPUT type=\"text\" value=\"dummy\"/>"
+               "  </FORM>"
+               "</DIV>");
+
+  // Test that we use the Content-Language meta tag as a fallback.
+  ExpectLocale("en-GB",
+               "<HTML>"
+               "  <HEAD>"
+               "    <META http-equiv=\"Content-Language\" content=\"en-GB\" />"
+               "  </HEAD>"
+               "  <FORM>"
+               "    <INPUT type=\"text\" value=\"dummy\"/>"
+               "  </FORM>"
+               "</HTML>");
+
+  // WebKit does absolutely no validation of the lang attribute; we shouldn't
+  // validate here either.
+  ExpectLocale("   this is-not a meaningful_locale! ",
+               "<FORM lang=\"   this is-not a meaningful_locale! \">"
+               "  <INPUT type=\"text\" value=\"dummy\"/>"
+               "</FORM>");
+}
+
 TEST_F(FormManagerTest, ExtractForms) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            "  <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
            "</FORM>");
 
   WebFrame* web_frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
 
   FormManager form_manager;
   form_manager.ExtractForms(web_frame);
 
   std::vector<FormData> forms;
   form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
   ASSERT_EQ(1U, forms.size());
 
   const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(string16(),
@@ skipping 25 matching lines @@
 
   FormManager form_manager;
   form_manager.ExtractForms(web_frame);
 
   std::vector<FormData> forms;
   form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
   ASSERT_EQ(2U, forms.size());
 
   // First form.
   const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(2U, fields.size());
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(string16(),
@@ skipping 64 matching lines @@
   form_manager.ExtractForms(web_frame);
 
   forms.clear();
   form_manager.GetForms(FormManager::REQUIRE_AUTOCOMPLETE, &forms);
   ASSERT_EQ(1U, forms.size());
 
   const FormData& form = forms[0];
   EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(web_frame->url()), form.origin);
   EXPECT_EQ(GURL("http://abc.com"), form.action);
+  EXPECT_EQ(std::string(), form.locale);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(2U, fields.size());
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(string16(),
@@ skipping 364 matching lines @@
 
   // There should be no forms after the call to Reset.
   form_manager.Reset();
 
   forms.clear();
   form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
   ASSERT_EQ(0U, forms.size());
 }
 
 TEST_F(FormManagerTest, Labels) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <LABEL for=\"firstname\"> First name: </LABEL>"
            "    <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            "  <LABEL for=\"lastname\"> Last name: </LABEL>"
            "    <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(
       FormField(ASCIIToUTF16("First name:"),
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("John"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(
       FormField(ASCIIToUTF16("Last name:"),
                 ASCIIToUTF16("lastname"),
                 ASCIIToUTF16("Smith"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
 TEST_F(FormManagerTest, LabelsWithSpans) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <LABEL for=\"firstname\"><span>First name: </span></LABEL>"
            "    <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            "  <LABEL for=\"lastname\"><span>Last name: </span></LABEL>"
            "    <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(
       FormField(ASCIIToUTF16("First name:"),
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("John"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(
       FormField(ASCIIToUTF16("Last name:"),
                 ASCIIToUTF16("lastname"),
                 ASCIIToUTF16("Smith"),
                 ASCIIToUTF16("text"),
                 20)));
   EXPECT_TRUE(fields[2].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("reply-send"),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
 // This test is different from FormManagerTest.Labels in that the label elements
 // for= attribute is set to the name of the form control element it is a label
 // for instead of the id of the form control element.  This is invalid because
 // the for= attribute must be set to the id of the form control element.
 TEST_F(FormManagerTest, InvalidLabels) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <LABEL for=\"firstname\"> First name: </LABEL>"
            "    <INPUT type=\"text\" name=\"firstname\" value=\"John\"/>"
            "  <LABEL for=\"lastname\"> Last name: </LABEL>"
            "    <INPUT type=\"text\" name=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(FormField(string16(),
                                            ASCIIToUTF16("firstname"),
                                            ASCIIToUTF16("John"),
                                            ASCIIToUTF16("text"),
                                            20)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(FormField(string16(),
                                            ASCIIToUTF16("lastname"),
@@ skipping 25 matching lines @@
   ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
 
   FormManager form_manager;
   form_manager.ExtractForms(web_frame);
 
   std::vector<FormData> forms;
   form_manager.GetForms(FormManager::REQUIRE_AUTOCOMPLETE, &forms);
   ASSERT_EQ(1U, forms.size());
 
   const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("Middle name:"),
                       ASCIIToUTF16("middlename"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromText) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  First name:"
            "    <INPUT type=\"text\" id=\"firstname\" value=\"John\"/>"
            "  Last name:"
            "    <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("First name:"),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromTextHidden) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  First name:"
            "    <INPUT type=\"hidden\" id=\"firstname\" value=\"John\"/>"
            "  Last name:"
            "    <INPUT type=\"hidden\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(FormField(string16(),
                                                      ASCIIToUTF16("firstname"),
                                                      ASCIIToUTF16("John"),
                                                      ASCIIToUTF16("hidden"),
                                                      0)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(FormField(string16(),
                                                      ASCIIToUTF16("lastname"),
                                                      ASCIIToUTF16("Smith"),
                                                      ASCIIToUTF16("hidden"),
                                                      0)));
   EXPECT_TRUE(fields[2].StrictlyEqualsHack(FormField(string16(),
                                                      ASCIIToUTF16("reply-send"),
                                                      string16(),
                                                      ASCIIToUTF16("submit"),
                                                      0)));
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromParagraph) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <P>First name:</P><INPUT type=\"text\" "
            "                           id=\"firstname\" value=\"John\"/>"
            "  <P>Last name:</P>"
            "    <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("First name:"),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromTableCell) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "<TABLE>"
            "  <TR>"
            "    <TD>First name:</TD>"
            "    <TD><INPUT type=\"text\" id=\"firstname\" value=\"John\"/></TD>"
            "  </TR>"
            "  <TR>"
            "    <TD>Last name:</TD>"
            "    <TD><INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/></TD>"
            "  </TR>"
            "  <TR>"
            "    <TD></TD>"
            "    <TD>"
            "      <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
            "    </TD>"
            "  </TR>"
            "</TABLE>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("First name:"),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromTableCellNested) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "<TABLE>"
            "  <TR>"
            "    <TD>"
            "      <FONT>"
            "        First name:"
            "      </FONT>"
            "      <FONT>"
            "        Bogus"
            "      </FONT>"
            "    </TD>"
@@ skipping 15 matching lines @@
            "      </FONT>"
            "    </TD>"
            "  </TR>"
            "  <TR>"
            "    <TD></TD>"
            "    <TD>"
            "      <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
            "    </TD>"
            "  </TR>"
            "</TABLE>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("First name:Bogus"),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredFromDefinitionList) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "<DL>"
            "  <DT>"
            "    <SPAN>"
            "      *"
            "    </SPAN>"
            "    <SPAN>"
            "      First name:"
            "    </SPAN>"
            "    <SPAN>"
            "      Bogus"
@@ skipping 12 matching lines @@
            "  <DD>"
            "    <FONT>"
            "      <INPUT type=\"text\" id=\"lastname\" value=\"Smith\"/>"
            "    </FONT>"
            "  </DD>"
            "  <DT></DT>"
            "  <DD>"
            "    <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
            "  </DD>"
            "</DL>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("*First name:Bogus"),
                       ASCIIToUTF16("firstname"),
                       ASCIIToUTF16("John"),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Last name:"),
                       ASCIIToUTF16("lastname"),
                       ASCIIToUTF16("Smith"),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredWithSameName) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  Address Line 1:"
            "    <INPUT type=\"text\" name=\"Address\"/>"
            "  Address Line 2:"
            "    <INPUT type=\"text\" name=\"Address\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("Address Line 1:"),
                       ASCIIToUTF16("Address"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("Address Line 2:"),
                       ASCIIToUTF16("Address"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[1]);
   EXPECT_EQ(FormField(string16(),
                       ASCIIToUTF16("reply-send"),
                       ASCIIToUTF16("Send"),
                       ASCIIToUTF16("submit"),
                       0),
             fields[2]);
 }
 
 TEST_F(FormManagerTest, LabelsInferredWithImageTags) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  Phone:"
            "  <input type=\"text\" name=\"dayphone1\">"
            "  <img/>"
            "  -"
            "  <img/>"
            "  <input type=\"text\" name=\"dayphone2\">"
            "  <img/>"
            "  -"
            "  <img/>"
            "  <input type=\"text\" name=\"dayphone3\">"
            "  ext.:"
            "  <input type=\"text\" name=\"dayphone4\">"
            "  <input type=\"text\" name=\"dummy\">"
            "  <input type=\"submit\" name=\"reply-send\" value=\"Send\">"
-           "</FORM>");
-
-  WebFrame* frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), frame);
-
-  WebVector<WebFormElement> forms;
-  frame->forms(forms);
-  ASSERT_EQ(1U, forms.size());
-
-  FormData form;
-  EXPECT_TRUE(FormManager::WebFormElementToFormData(forms[0],
-                                                    FormManager::REQUIRE_NONE,
-                                                    true,
-                                                    &form));
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(6U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("Phone:"),
                       ASCIIToUTF16("dayphone1"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
@@ skipping 755 matching lines @@
 
   WebVector<WebFormElement> forms;
   frame->forms(forms);
   ASSERT_EQ(1U, forms.size());
 
   FormData form;
   EXPECT_TRUE(FormManager::WebFormElementToFormData(forms[0],
                                                     FormManager::REQUIRE_NONE,
                                                     true,
                                                     &form));
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(5U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("Phone:"),
                       ASCIIToUTF16("dayphone1"),
                       string16(),
                       ASCIIToUTF16("text"),
                       20),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
@@ skipping 44 matching lines @@
 
   WebVector<WebFormElement> forms;
   frame->forms(forms);
   ASSERT_EQ(1U, forms.size());
 
   FormData form;
   EXPECT_TRUE(FormManager::WebFormElementToFormData(forms[0],
                                                     FormManager::REQUIRE_NONE,
                                                     true,
                                                     &form));
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
   EXPECT_EQ(GURL(frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(7U, fields.size());
   EXPECT_EQ(FormField(ASCIIToUTF16("Phone:"),
                       ASCIIToUTF16("dayphone1"),
                       string16(),
                       ASCIIToUTF16("text"),
                       3),
             fields[0]);
   EXPECT_EQ(FormField(ASCIIToUTF16("-"),
@@ skipping 290 matching lines @@
   // Auto-filled attribute not set yet.
   EXPECT_FALSE(form_manager.FormWithNodeIsAutoFilled(firstname));
 
   // Set the auto-filled attribute.
   firstname.setAutofilled(true);
 
   EXPECT_TRUE(form_manager.FormWithNodeIsAutoFilled(firstname));
 }
 
 TEST_F(FormManagerTest, LabelsHiddenFields) {
-  LoadHTML("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
+  FormData form;
+  LoadForm("<FORM name=\"TestForm\" action=\"http://cnn.com\" method=\"post\">"
            "  <LABEL for=\"firstname\"> First name: </LABEL>"
            "    <INPUT type=\"hidden\" id=\"firstname\" value=\"John\"/>"
            "  <LABEL for=\"lastname\"> Last name: </LABEL>"
            "    <INPUT type=\"hidden\" id=\"lastname\" value=\"Smith\"/>"
            "  <INPUT type=\"submit\" name=\"reply-send\" value=\"Send\"/>"
-           "</FORM>");
-
-  WebFrame* web_frame = GetMainFrame();
-  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
-
-  FormManager form_manager;
-  form_manager.ExtractForms(web_frame);
-
-  std::vector<FormData> forms;
-  form_manager.GetForms(FormManager::REQUIRE_NONE, &forms);
-  ASSERT_EQ(1U, forms.size());
-
-  const FormData& form = forms[0];
-  EXPECT_EQ(ASCIIToUTF16("TestForm"), form.name);
-  EXPECT_EQ(GURL(web_frame->url()), form.origin);
-  EXPECT_EQ(GURL("http://cnn.com"), form.action);
+           "</FORM>",
+           &form);
+  ExpectDefaultForm(form);
 
   const std::vector<FormField>& fields = form.fields;
   ASSERT_EQ(3U, fields.size());
   EXPECT_TRUE(fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
                 ASCIIToUTF16("John"),
                 ASCIIToUTF16("hidden"),
                 0)));
   EXPECT_TRUE(fields[1].StrictlyEqualsHack(
@@ skipping 24 matching lines @@
 
   WebElement e = web_frame->document().getElementById("firstname");
   WebFormControlElement firstname = e.to<WebFormControlElement>();
 
   // Hidden form control element should not have a label set.
   FormManager form_manager;
   EXPECT_EQ(string16(), form_manager.LabelForElement(firstname));
 }
 
 }  // namespace