Source/modules/geolocation/testing/InternalsGeolocation.cpp - Issue 322583002: Fix InternalsGeolocation::setGeolocationClientMock to actually set the test client for all Geolocat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/testing/InternalsGeolocation.cpp

Issue 322583002: Fix InternalsGeolocation::setGeolocationClientMock to actually set the test client for all Geolocat… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/geolocation/testing/InternalsGeolocation.cpp

diff --git a/Source/modules/geolocation/testing/InternalsGeolocation.cpp b/Source/modules/geolocation/testing/InternalsGeolocation.cpp

index 4de6488e9f88d72f6ee60b3fb7ce715f4ccd8be6..06a1e6a07d8161344dda08c09758b0ca5045844f 100644

--- a/Source/modules/geolocation/testing/InternalsGeolocation.cpp

+++ b/Source/modules/geolocation/testing/InternalsGeolocation.cpp

@@ -47,8 +47,8 @@ void InternalsGeolocation::setGeolocationClientMock(Internals&, Document* docume

ASSERT(document && document->frame());

GeolocationClientMock* client = new GeolocationClientMock();

- for (LocalFrame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().nextSibling())

- GeolocationController::from(document->frame())->setClientForTest(client);

+ for (LocalFrame* childFrame = document->page()->mainFrame(); childFrame; childFrame = childFrame->tree().traverseNext())

+ GeolocationController::from(childFrame)->setClientForTest(client);

}

void InternalsGeolocation::setGeolocationPosition(Internals&, Document* document, double latitude, double longitude, double accuracy)

« no previous file with comments | « no previous file | no next file » | no next file with comments »