Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 322553005: Improve handling of <video>, <figure> and <br> (Closed)

Created:
6 years, 6 months ago by Yaron
Modified:
6 years, 6 months ago
Reviewers:
cjhopman, nyquist
CC:
kuan, nyquist
Base URL:
https://code.google.com/p/dom-distiller/@master
Visibility:
Public.

Description

Improve handling of <video>, <figure> and <br> Omit <video> and <figure> from the document Boilerpipe sees as they have text that can confuse processing. Instead treat these (and <br>s) in a similar manner to data tables and <img> tags. This shows a very minor decline in eval but it's a false negative as a <figcaption> is omitted from the text only response, but is included later when reconstructing the page. BUG=376107, 376102, 378385 R=cjhopman@chromium.org, nyquist@chromium.org Committed: b6100c8

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M src/com/dom_distiller/client/ContentExtractor.java View 1 3 chunks +9 lines, -8 lines 0 comments Download
M src/com/dom_distiller/client/FilteringDomVisitor.java View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/com/dom_distiller/client/RelevantElementsFinder.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yaron
6 years, 6 months ago (2014-06-06 23:00:42 UTC) #1
cjhopman
lgtm
6 years, 6 months ago (2014-06-06 23:06:23 UTC) #2
nyquist
lgtm
6 years, 6 months ago (2014-06-06 23:40:36 UTC) #3
Yaron
6 years, 6 months ago (2014-06-09 16:34:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as rb6100c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698