Issue 322543002: Increase optimization threshold since unoptimized code runs faster. Faster startup time, no measura…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322543002: Increase optimization threshold since unoptimized code runs faster. Faster startup time, no measura… (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 5 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Increase optimization threshold since unoptimized code runs faster. Faster startup time, no measurable performance degradation. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37091

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/code_generator.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #2 manually as r37091 (presubmit successful).

6 years, 6 months ago (2014-06-06 18:13:18 UTC) #3

zra

6 years, 5 months ago (2014-07-18 16:10:27 UTC) #4

Message was sent while issue was closed.

On 2014/06/06 18:13:18, srdjan wrote:
> Committed patchset #2 manually as r37091 (presubmit successful).

DBC

This change caused performance degradations > 5% for several benchmarks on ARM.
Maybe it's because unoptimized code hasn't improved as much there? Maybe we
should consider arch-specific thresholds?

Expand Messages | Collapse Messages