Adding OverrideStringResource API to ResourceBundle.

ui/base/resource/resource_bundle.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_
 #define UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_
 
 #include <map>
 #include <string>
 
@@ skipping 227 matching lines @@
   const gfx::Font& GetFont(FontStyle style);
 
   // Resets and reloads the cached fonts.  This is useful when the fonts of the
   // system have changed, for example, when the locale has changed.
   void ReloadFonts();
 
   // Overrides the path to the pak file from which the locale resources will be
   // loaded. Pass an empty path to undo.
   void OverrideLocalePakForTest(const base::FilePath& pak_path);
 
+  // Overrides a localized string resource with the given string. If no delegate
+  // is present, the |overridding_string| will be returned when getting the
+  // localized string |message_id|. This is intended to be used in conjunction
+  // with field trials and the variations service to experiment with different
+  // UI strings.
+  void OverrideStringResource(int message_id,
+                              const base::string16& overridding_string);

[grt (UTC plus 2), 2014/06/09 16:54:44]

nit: overridding_string -> string here and in comment. it's nice to not wrap
this, and the purpose is clear enough given the name of the method.

[jwd, 2014/06/10 20:59:25]

Done.

+
   // Returns the full pathname of the locale file to load.  May return an empty
   // string if no locale data files are found and |test_file_exists| is true.
   // Used on Android to load the local file in the browser process and pass it
   // to the sandboxed renderer process.
   base::FilePath GetLocaleFilePath(const std::string& app_locale,
                                    bool test_file_exists);
 
   // Returns the maximum scale factor currently loaded.
   // Returns SCALE_FACTOR_100P if no resource is loaded.
   ScaleFactor GetMaxScaleFactor() const;
@@ skipping 126 matching lines @@
   scoped_ptr<gfx::FontList> small_font_list_;
   scoped_ptr<gfx::FontList> small_bold_font_list_;
   scoped_ptr<gfx::FontList> medium_font_list_;
   scoped_ptr<gfx::FontList> medium_bold_font_list_;
   scoped_ptr<gfx::FontList> large_font_list_;
   scoped_ptr<gfx::FontList> large_bold_font_list_;
   scoped_ptr<gfx::FontList> web_font_list_;
 
   base::FilePath overridden_pak_path_;
 
+  std::map<int, base::string16> overridden_strings_;

[grt (UTC plus 2), 2014/06/09 16:54:44]

suggestion: make a typdef for this up at the top of the private section
(honoring the ordering prescribed by the style guide)
  typedef std::map<int, base::string16> IdToStringMap;

[jwd, 2014/06/10 20:59:25]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ResourceBundle);
 };
 
 }  // namespace ui
 
 // TODO(beng): Someday, maybe, get rid of this.
 using ui::ResourceBundle;
 
 #endif  // UI_BASE_RESOURCE_RESOURCE_BUNDLE_H_