Issue 322483005: Final Observatory 1.5 fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322483005: Final Observatory 1.5 fixes (Closed)

Created:
6 years, 6 months ago by Cutch

Modified:
6 years, 6 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Final Observatory 1.5 fixes - Don't request the empty path from service. - Don't replace the url path (Fixes Dartium). - Disable dart:io link until UI is completed. - Disable back and forward buttons because they act weird in DevTools. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=37125

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
M	runtime/bin/vmservice/client/lib/service_html.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/application.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/app/location_manager.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/nav_bar.html	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/322483005/diff/1/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html File runtime/bin/vmservice/client/lib/src/elements/nav_bar.html (right): https://codereview.chromium.org/322483005/diff/1/runtime/bin/vmservice/client/lib/src/elements/nav_bar.html#newcode178 runtime/bin/vmservice/client/lib/src/elements/nav_bar.html:178: button { On Linux the buttons are the same ...

6 years, 6 months ago (2014-06-06 17:18:45 UTC) #1

Cutch

6 years, 6 months ago (2014-06-09 18:04:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r37125 (presubmit successful).

Expand Messages | Collapse Messages