DevTools: Fix remote device debugging

DevTools: Fix remote device debugging

R=dgozman
BUG=381184
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175669

[dgozman, 2014-06-06 13:13:06]

I think, there should be removed screencast directory in this patch.

https://codereview.chromium.org/322483004/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/ScreencastApp.js (right):

https://codereview.chromium.org/322483004/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/ScreencastApp.js:14: this._currentScreencastState
= WebInspector.settings.createSetting("currentScreencastState", "");
We should initialize both these settings with "disabled", since we removed the
"only from the list of states" logic in previous patch.

[apavlov, 2014-06-06 13:15:33]

> I think, there should be removed screencast directory in this patch.

Ha-ha, no! It was never checked in, being just my local file (which confused me
at the time of writing the patch) :(

https://codereview.chromium.org/322483004/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/ScreencastApp.js (right):

https://codereview.chromium.org/322483004/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/ScreencastApp.js:14: this._currentScreencastState
= WebInspector.settings.createSetting("currentScreencastState", "");
On 2014/06/06 13:13:06, dgozman wrote:
> We should initialize both these settings with "disabled", since we removed the
> "only from the list of states" logic in previous patch.

Done.

[dgozman, 2014-06-06 13:19:32]

lgtm

https://codereview.chromium.org/322483004/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/main/ScreencastApp.js (right):

https://codereview.chromium.org/322483004/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/main/ScreencastApp.js:13: var lastScreencastState =
WebInspector.settings.createSetting("lastScreencastState", "disabled");
Actually, it's better to start with "left", so users immediately see the feature
they came for. Sorry for that.

[apavlov, 2014-06-06 13:27:51]

On 2014/06/06 13:19:32, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/322483004/diff/20001/Source/devtools/front_en...
> File Source/devtools/front_end/main/ScreencastApp.js (right):
> 
>
https://codereview.chromium.org/322483004/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/main/ScreencastApp.js:13: var lastScreencastState =
> WebInspector.settings.createSetting("lastScreencastState", "disabled");
> Actually, it's better to start with "left", so users immediately see the
feature
> they came for. Sorry for that.

NP, fixed!

[apavlov, 2014-06-06 13:30:27]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-06-06 13:31:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/322483004/10003

[commit-bot: I haz the power, 2014-06-06 14:36:56]

Change committed as 175669