Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 322463005: DevTools: include DebuggerScriptSource.h with path. (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
aandrey, yurys
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

DevTools: include DebuggerScriptSource.h with path. otherwise compiler includes the old version of the file from gen/blink instead of gen/blink/core BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175664

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/v8/ScriptDebugServer.cpp View 2 chunks +1 line, -1 line 1 comment Download

Messages

Total messages: 13 (0 generated)
loislo
6 years, 6 months ago (2014-06-06 10:47:12 UTC) #1
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-06 10:47:19 UTC) #2
loislo
The CQ bit was unchecked by loislo@chromium.org
6 years, 6 months ago (2014-06-06 10:47:21 UTC) #3
yurys
lgtm
6 years, 6 months ago (2014-06-06 10:51:58 UTC) #4
yurys
I guess the file should be generated into core/inspector instead. Please clarify before landing.
6 years, 6 months ago (2014-06-06 10:53:22 UTC) #5
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-06 10:58:27 UTC) #6
loislo
The CQ bit was unchecked by loislo@chromium.org
6 years, 6 months ago (2014-06-06 10:58:31 UTC) #7
loislo
On 2014/06/06 10:53:22, yurys wrote: > I guess the file should be generated into core/inspector ...
6 years, 6 months ago (2014-06-06 11:01:59 UTC) #8
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-06 11:02:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/322463005/1
6 years, 6 months ago (2014-06-06 11:02:20 UTC) #10
aandrey
lgtm https://codereview.chromium.org/322463005/diff/1/Source/bindings/v8/ScriptDebugServer.cpp File Source/bindings/v8/ScriptDebugServer.cpp (right): https://codereview.chromium.org/322463005/diff/1/Source/bindings/v8/ScriptDebugServer.cpp#newcode41 Source/bindings/v8/ScriptDebugServer.cpp:41: #include "core/DebuggerScriptSource.h" +1 for core/inspector/
6 years, 6 months ago (2014-06-06 11:03:08 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 12:05:53 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:00:47 UTC) #13
Message was sent while issue was closed.
Change committed as 175664

Powered by Google App Engine
This is Rietveld 408576698