autocomplete: support address-line3, address-level{1,2,3}

components/autofill/content/renderer/form_cache.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/form_cache.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/form_field_data_predictions.h"
 #include "grit/components_strings.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
+#include "third_party/WebKit/public/web/WebConsoleMessage.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFormControlElement.h"
 #include "third_party/WebKit/public/web/WebFormElement.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebNodeList.h"
 #include "third_party/WebKit/public/web/WebSelectElement.h"
 #include "third_party/WebKit/public/web/WebTextAreaElement.h"
 #include "ui/base/l10n/l10n_util.h"
 
+using blink::WebConsoleMessage;
 using blink::WebDocument;
 using blink::WebFormControlElement;
 using blink::WebFormElement;
 using blink::WebFrame;
 using blink::WebInputElement;
 using blink::WebSelectElement;
 using blink::WebTextAreaElement;
 using blink::WebString;
 using blink::WebVector;
 
@@ skipping 35 matching lines @@
                                 std::vector<FormData>* forms) {
   WebDocument document = frame.document();
   if (document.isNull())
     return;
 
   web_documents_.insert(document);
 
   WebVector<WebFormElement> web_forms;
   document.forms(web_forms);
 
+  // We log an error message for deprecated attributes, but only the first time

[Ilya Sherman, 2014/06/10 00:40:40]

nit: "We log" -> "Log"

[Evan Stade, 2014/06/12 01:49:47]

Done.

+  // the form is parsed.
+  bool log_deprecation_messages =
+      parsed_forms_.find(&frame) == parsed_forms_.end();
+
   size_t num_fields_seen = 0;
   for (size_t i = 0; i < web_forms.size(); ++i) {
     WebFormElement form_element = web_forms[i];
 
     std::vector<WebFormControlElement> control_elements;
     ExtractAutofillableElements(form_element, autofill::REQUIRE_NONE,
                                 &control_elements);
 
     size_t num_editable_elements = 0;
     for (size_t j = 0; j < control_elements.size(); ++j) {
       WebFormControlElement element = control_elements[j];
 
+      if (log_deprecation_messages) {
+        std::string autocomplete_attribute =
+            base::UTF16ToUTF8(element.getAttribute("autocomplete"));
+
+        static const char* deprecated[] = { "region", "locality" };

[Ilya Sherman, 2014/06/10 00:40:40]

nit: "const char*" -> "const char* const"

[Evan Stade, 2014/06/12 01:49:46]

Done.

+        for (size_t i = 0; i < arraysize(deprecated); ++i) {
+          if (autocomplete_attribute.find(deprecated[i]) != std::string::npos) {
+            WebConsoleMessage console_message = WebConsoleMessage(
+                WebConsoleMessage::LevelLog,

[Ilya Sherman, 2014/06/10 00:40:40]

Wouldn't LevelWarning or LevelError be more appropriate?

[Evan Stade, 2014/06/12 01:49:46]

yea, I think warning is correct

+                WebString(base::ASCIIToUTF16(std::string("autocomplete='") +
+                    deprecated[i] + "' is deprecated and will soon be ignored. "
+                    "See http://goo.gl/YjeSsW")));
+            element.document().frame()->addMessageToConsole(console_message);
+          }
+        }
+      }
+
       // Save original values of <select> elements so we can restore them
       // when |ClearFormWithNode()| is invoked.
       if (IsSelectElement(element)) {
         const WebSelectElement select_element =
             element.toConst<WebSelectElement>();
         initial_select_values_.insert(std::make_pair(select_element,
                                                      select_element.value()));
         ++num_editable_elements;
       } else if (IsTextAreaElement(element)) {
         ++num_editable_elements;
@@ skipping 175 matching lines @@
       element->setAttribute("placeholder",
                             WebString(base::UTF8ToUTF16(placeholder)));
     }
     element->setAttribute("title", WebString(title));
   }
 
   return true;
 }
 
 }  // namespace autofill