Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 322433006: Fork of the Android NDK crazy linker. (Closed)

Created:
6 years, 6 months ago by simonb (inactive)
Modified:
6 years, 6 months ago
Reviewers:
simonb1, Chris Palmer, Daniel Berlin, bulach, rmcilroy, palmer, open-source-third-party-reviews, security
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fork of the Android NDK crazy linker. - Forked from: android/platform/ndk/2b709a01b4d9fd1302689277ccfd475cab70a5e4 BUG=384700 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276328

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase to android / platform/ndk / 2b709a01b4d9fd1302689277ccfd475cab70a5e4 #

Patch Set 3 : Rebase to android/platform/ndk/f96c7168b688f2d8cc99c220e7a40e3739476848 #

Patch Set 4 : Bring README.chromium up to date. #

Patch Set 5 : Add a required license header to a cpp module, missing in the original. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11001 lines, --1 lines) Patch
A + third_party/android_crazy_linker/LICENSE View 1 chunk +28 lines, -0 lines 0 comments Download
A + third_party/android_crazy_linker/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/android_crazy_linker/README.chromium View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/Android.mk View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/DESIGN.TXT View 1 chunk +205 lines, -0 lines 0 comments Download
A + third_party/android_crazy_linker/src/LICENSE View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/README.TXT View 1 chunk +137 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/include/crazy_linker.h View 1 chunk +335 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/minitest View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_api.cpp View 1 chunk +358 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_ashmem.h View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_ashmem.cpp View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_ashmem_unittest.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_debug.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_debug.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.h View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_loader.cpp View 1 1 chunk +342 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.h View 1 1 chunk +95 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_relocations.cpp View 1 1 chunk +535 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.h View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_relro.cpp View 1 chunk +228 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_symbols.h View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_symbols.cpp View 1 chunk +146 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_view.h View 1 chunk +109 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_elf_view.cpp View 1 2 3 4 1 chunk +125 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_error.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_error.cpp View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_error_unittest.cpp View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_globals.h View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_globals.cpp View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_globals_unittest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_library_list.h View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_library_list.cpp View 1 1 chunk +388 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_library_view.h View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_library_view.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_line_reader.h View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_line_reader.cpp View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_line_reader_unittest.cpp View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_memory_mapping.h View 1 chunk +88 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_proc_maps.h View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_proc_maps.cpp View 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_proc_maps_unittest.cpp View 1 chunk +214 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_rdebug.h View 1 chunk +231 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_rdebug.cpp View 1 1 chunk +429 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_search_path_list.h View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_search_path_list.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_search_path_list_unittest.cpp View 1 chunk +90 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_shared_library.h View 1 chunk +208 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp View 1 2 1 chunk +451 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_system.h View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_system.cpp View 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_system_mock.h View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_system_mock.cpp View 1 chunk +387 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_system_unittest.cpp View 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_thread.h View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_thread.cpp View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_thread_unittest.cpp View 1 chunk +124 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_util.h View 1 chunk +302 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_util.cpp View 1 chunk +124 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_util_unittest.cpp View 1 chunk +229 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_wrappers.h View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp View 1 chunk +277 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/elf_traits.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/linker_phdr.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/src/linker_phdr.cpp View 1 chunk +407 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/Android.mk View 1 chunk +126 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/bar.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/bar_with_relro.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/bench_load_library.cpp View 1 chunk +150 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/foo.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/foo2.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/foo_with_relro.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/foo_with_static_constructor.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/jni_lib.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_constructors_destructors.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_dl_wrappers.cpp View 1 chunk +50 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_jni_hooks.cpp View 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_load_library.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_load_library_callbacks.cpp View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_load_library_depends.cpp View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_relocated_shared_relro.cpp View 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_search_path_list.cpp View 1 chunk +134 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_shared_relro.cpp View 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_two_shared_relros.cpp View 1 chunk +122 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/test_util.h View 1 chunk +465 lines, -0 lines 0 comments Download
A third_party/android_crazy_linker/src/tests/zoo.cpp View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
simonb1
6 years, 6 months ago (2014-06-06 13:14:11 UTC) #1
bulach
lgtm, as per previous talks with security and the ndk folks (need to add security ...
6 years, 6 months ago (2014-06-06 14:41:49 UTC) #2
simonb1
6 years, 6 months ago (2014-06-06 14:53:54 UTC) #3
rmcilroy
Lgtm, thanks. https://codereview.chromium.org/322433006/diff/1/third_party/android_crazy_linker/README.chromium File third_party/android_crazy_linker/README.chromium (right): https://codereview.chromium.org/322433006/diff/1/third_party/android_crazy_linker/README.chromium#newcode3 third_party/android_crazy_linker/README.chromium:3: Version: unknown You could just put the ...
6 years, 6 months ago (2014-06-06 17:54:26 UTC) #4
Daniel Berlin
lgtm
6 years, 6 months ago (2014-06-09 18:27:28 UTC) #5
palmer
lgtm
6 years, 6 months ago (2014-06-09 23:17:36 UTC) #6
simonb1
The CQ bit was checked by simonb@google.com
6 years, 6 months ago (2014-06-10 13:31:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/322433006/60001
6 years, 6 months ago (2014-06-10 13:35:47 UTC) #8
simonb1
The CQ bit was checked by simonb@google.com
6 years, 6 months ago (2014-06-10 15:35:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/322433006/80001
6 years, 6 months ago (2014-06-10 15:38:37 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 22:25:09 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 04:26:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18775)
6 years, 6 months ago (2014-06-11 04:27:00 UTC) #13
simonb1
The CQ bit was checked by simonb@google.com
6 years, 6 months ago (2014-06-11 10:10:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/322433006/80001
6 years, 6 months ago (2014-06-11 10:11:49 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 10:14:36 UTC) #16
Message was sent while issue was closed. 
Change committed as 276328

Powered by Google App Engine
This is Rietveld 408576698