Create VTVideoDecodeAccelerator

content/common/gpu/media/vt_video_decode_accelerator.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_GPU_MEDIA_VT_VIDEO_DECODE_ACCELERATOR_H_
+#define CONTENT_COMMON_GPU_MEDIA_VT_VIDEO_DECODE_ACCELERATOR_H_
+
+#include <stdint.h>

[scherkus (not reviewing), 2014/06/09 16:02:07]

what's this used for?

[sandersd (OOO until July 31), 2014/06/10 01:02:44]

int32_t, but the include is implied by the fact that it is an interface
implementation.

I'm not sure of the IWYU status of Chromium, it sounds like the idea is
encouraged but the tool is broken.

+
+#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "content/common/content_export.h"
+#include "content/common/gpu/media/video_decode_accelerator_impl.h"
+#include "ui/gl/gl_context_cgl.h"
+
+namespace content {
+
+class CONTENT_EXPORT VTVideoDecodeAccelerator

[scherkus (not reviewing), 2014/06/09 16:02:07]

do you need CONTENT_EXPORT yet? usually it's needed when the class is
instantiated outside of content library (e.g., for unit tests or use outside of
content)

[scherkus (not reviewing), 2014/06/09 16:02:07]

docs for the class

[sandersd (OOO until July 31), 2014/06/10 01:02:45]

Done.

[sandersd (OOO until July 31), 2014/06/10 01:02:45]

Done.

+    : public VideoDecodeAcceleratorImpl,
+      public base::NonThreadSafe {
+ public:
+  explicit VTVideoDecodeAccelerator(CGLContextObj cgl_context);
+  virtual ~VTVideoDecodeAccelerator();
+
+  // VideoDecodeAcceleratorImpl implementation.
+  virtual bool Initialize(
+      media::VideoCodecProfile profile,
+      Client* client) OVERRIDE;
+  virtual void Decode(const media::BitstreamBuffer& bitstream) OVERRIDE;
+  virtual void AssignPictureBuffers(
+      const std::vector<media::PictureBuffer>& pictures) OVERRIDE;
+  virtual void ReusePictureBuffer(int32_t picture_id) OVERRIDE;
+  virtual void Flush() OVERRIDE;
+  virtual void Reset() OVERRIDE;
+  virtual void Destroy() OVERRIDE;
+
+ private:
+  base::WeakPtrFactory<VTVideoDecodeAccelerator> weak_this_factory_;

[scherkus (not reviewing), 2014/06/09 16:02:07]

this should be the last member - feel free to copy the comment as well

see
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/serial_...
for an example

see https://code.google.com/p/chromium/issues/detail?id=351048 for reasoning

[sandersd (OOO until July 31), 2014/06/10 01:02:44]

Done.

+  base::WeakPtr<VTVideoDecodeAccelerator> weak_this_;
+  scoped_refptr<base::MessageLoopProxy> loop_proxy_;
+  CGLContextObj cgl_context_;
+  media::VideoDecodeAccelerator::Client* client_;
+
+  DISALLOW_COPY_AND_ASSIGN(VTVideoDecodeAccelerator);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_COMMON_GPU_MEDIA_VT_VIDEO_DECODE_ACCELERATOR_H_