Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 322423004: [Telemetry] Decrease `powermetrics` sampling rate on Mac (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Decrease `powermetrics` sampling rate on Mac This patch changes the sampling rate of `powermetrics` from 20hz to the default - 5s. We don't need the extra resolution for our measurements and it seems that increasing the sampling rate draws power in and of itself which affects what's being measured. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jeremy
6 years, 6 months ago (2014-06-11 17:54:04 UTC) #1
tonyg
lgtm
6 years, 6 months ago (2014-06-11 17:54:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/322423004/1
6 years, 6 months ago (2014-06-11 17:59:56 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:28:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:31:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38005) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26151) win_chromium_x64_rel ...
6 years, 6 months ago (2014-06-11 21:31:19 UTC) #6
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-11 22:47:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/322423004/1
6 years, 6 months ago (2014-06-11 22:49:39 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:52:19 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:53:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38115)
6 years, 6 months ago (2014-06-11 22:53:59 UTC) #11
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-12 04:14:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/322423004/1
6 years, 6 months ago (2014-06-12 04:17:02 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 09:17:37 UTC) #14
Message was sent while issue was closed.
Change committed as 276597

Powered by Google App Engine
This is Rietveld 408576698