Issue 322423002: Revert of second try at landing improved blur rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322423002: Revert of second try at landing improved blur rect (Closed)

Created:
6 years, 6 months ago by reed1

Modified:
6 years, 6 months ago

Reviewers:
humper, bsalomon, reed2

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of second try at landing improved blur rect (https://codereview.chromium.org/325703002/) Reason for revert: broke some fast/canvas layout tests Original issue's description: > second try at landing improved blur rect > > BUG=skia:2095 > TBR=bsalomon > > Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76 TBR=bsalomon@google.com,reed@chromium.org,humper@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2095 Committed: https://skia.googlesource.com/skia/+/b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -125 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View	8 chunks	+101 lines, -104 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/BlurTest.cpp	View	4 chunks	+6 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/322423002/1

6 years, 6 months ago (2014-06-11 14:26:18 UTC) #2

commit-bot: I haz the power

6 years, 6 months ago (2014-06-11 14:26:27 UTC) #3

Message was sent while issue was closed.

Change committed as b0b1aa04ed82a7cb16c7e6a06d92a411d7bd3749