Issue 322403007: Fix a number of issues with iOS build.

Issue 322403007: Fix a number of issues with iOS build. (Closed)

Created:
6 years, 6 months ago by jvanverth1

Modified:
6 years, 6 months ago

Reviewers:
tfarina, bsalomon, caryclark, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix a number of issues with iOS build. Set pointer to root view in window (for SampleApp) Set up the correct function pointer for GL multisampling Remove use of SkBitmap::setConfig() Remove incomplete iOS implementation of SkFILE (use SkOSFile for now) Committed: https://skia.googlesource.com/skia/+/66c9582d1bed717d72c9d3f789f761cb08e28264

Patch Set 1 #

Patch Set 2 : Remove unnecessary image #

Total comments: 1

Patch Set 3 : Remove SKOSFile_iOS.mm a little more cleanly (and clearly) #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	experimental/iOSSampleApp/iPad/AppDelegate_iPad.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	experimental/iOSSampleApp/iPhone/AppDelegate_iPhone.mm	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	gyp/SampleApp.gyp	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/ios/SkImageDecoder_iOS.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/322403007/diff/20001/src/utils/ios/SkOSFile_iOS.mm File src/utils/ios/SkOSFile_iOS.mm (right): https://codereview.chromium.org/322403007/diff/20001/src/utils/ios/SkOSFile_iOS.mm#newcode12 src/utils/ios/SkOSFile_iOS.mm:12: /* why you do this?

6 years, 6 months ago (2014-06-11 19:12:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/322403007/40001

6 years, 6 months ago (2014-06-11 20:33:49 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-11 20:59:32 UTC) #6

Message was sent while issue was closed.

Change committed as 66c9582d1bed717d72c9d3f789f761cb08e28264

Expand Messages | Collapse Messages