Issue 322403006: MIPS: Fixed flooring division by a power of 2, once again...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322403006: MIPS: Fixed flooring division by a power of 2, once again... (Closed)

Created:
6 years, 6 months ago by kilvadyb

Modified:
6 years, 6 months ago

Reviewers:
Sven Panne, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Fixed flooring division by a power of 2, once again... Port r21769 (52e191b) Original commit message: Avoid right shifts by zero bits: On ARM it actually means shifting by 32 bits (correctness issue) and on other platforms they are useless (performance issue). This is fix for the fix in r20544. BUG=v8:3259 LOG=y

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		4 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 6 months ago (2014-06-13 06:40:19 UTC) #4

On 2014/06/11 20:06:51, Paul Lind wrote:
> Committed as r21780.

Closing, no clue why it wasn't done...

Expand Messages | Collapse Messages