Issue 322403005: Pepper: Remove nacl_entry_points.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 322403005: Pepper: Remove nacl_entry_points.h. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Remove nacl_entry_points.h. This function indirection is no longer necessary, and I was getting frustrated by having the type signature of LaunchSelLdr twice in the source. I came across this in an experimental CL modifying LaunchSelLdr to also receive information for the user nexe. BUG=333950 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276466

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -65 lines)			Patch
M	components/nacl/renderer/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/nacl/renderer/nexe_load_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/module_ppapi.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	ppapi/native_client/src/trusted/plugin/nacl_entry_points.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc	View	2 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

teravest

6 years, 6 months ago (2014-06-11 18:44:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r276466 (presubmit successful).

Expand Messages | Collapse Messages