Timeline: disable start/stop button and properly indicate progress when stop is pending

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 652 matching lines @@
 
         for (var i = 0; i < this._overviewControls.length; ++i)
             this._overviewControls[i].timelineStarted();
 
         if (userInitiated)
             WebInspector.userMetrics.TimelineStarted.record();
     },
 
     _stopRecording: function()
     {
+        this._stopPending = true;
+        this._updateToggleTimelineButton(false);
         this._userInitiatedRecording = false;
         this._model.stopRecording();
+        if (this._progressElement)
+            this._updateProgress(WebInspector.UIString("Retrieving events\u2026"));
 
         for (var i = 0; i < this._overviewControls.length; ++i)
             this._overviewControls[i].timelineStopped();
     },
 
     _onProfilingStateChanged: function()
     {
         this._updateToggleTimelineButton(this.toggleTimelineButton.toggled);
     },
 
     /**
      * @param {boolean} toggled
      */
     _updateToggleTimelineButton: function(toggled)
     {
-        var enable = toggled || !this._model.target().profilingLock.isAcquired();
-        this.toggleTimelineButton.setEnabled(enable);
         this.toggleTimelineButton.toggled = toggled;
-        if (enable)
-            this.toggleTimelineButton.title = toggled ? WebInspector.UIString("Stop") : WebInspector.UIString("Record");
-        else
+        if (toggled) {
+            this.toggleTimelineButton.title = WebInspector.UIString("Stop");
+            this.toggleTimelineButton.setEnabled(true);
+        } else if (this._stopPending) {
+            this.toggleTimelineButton.title = WebInspector.UIString("Stop pending");
+            this.toggleTimelineButton.setEnabled(false);
+        } else if (this._model.target().profilingLock.isAcquired()) {
             this.toggleTimelineButton.title = WebInspector.UIString("Another profiler is already active");

[yurys, 2014/06/16 07:18:07]

Hm, why do we show this message only when  toggled=false? It seems to me that we
need to to this when toggled=true and threre is already another profile running,
wdyt?

+            this.toggleTimelineButton.setEnabled(false);
+        } else {
+            this.toggleTimelineButton.title = WebInspector.UIString("Record");
+            this.toggleTimelineButton.setEnabled(true);
+        }
     },
 
     /**
      * @return {boolean}
      */
     _toggleTimelineButtonClicked: function()
     {
         if (!this.toggleTimelineButton.enabled())
             return true;
         if (this._operationInProgress)
@@ skipping 79 matching lines @@
 
     _hideProgressPane: function()
     {
         if (this._progressElement)
             this._progressElement.remove();
         delete this._progressElement;
     },
 
     _onRecordingStopped: function()
     {
+        this._stopPending = false;
         this._updateToggleTimelineButton(false);
         if (this._lazyFrameModel) {
             if (this._tracingTimelineModel) {
                 this._lazyFrameModel.reset();
                 this._lazyFrameModel.addTraceEvents(this._tracingTimelineModel.inspectedTargetEvents(), this._tracingModel.sessionId());
                 this._overviewPane.update();
             } else if (WebInspector.experimentsSettings.timelineNoLiveUpdate.isEnabled()) {
                 this._lazyFrameModel.reset();
                 this._lazyFrameModel.addRecords(this._model.records());
             }
@@ skipping 634 matching lines @@
      * @param {!WebInspector.TimelineModel.Record} record
      * @return {boolean}
      */
     accept: function(record)
     {
         return !this._hiddenRecords[record.type()];
     },
 
     __proto__: WebInspector.TimelineModel.Filter.prototype
 }