Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 322403004: Timeline: disable start/stop button and properly indicate progress when stop is pending (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: disable start/stop button and properly indicate progress when stop is pending Now that we may fetch a lot of trace (or buffered timeline) events after timeline is stopped, we need a better indication of that. The button remaining red after it's pressed is very annoying. Let's turn it off and disable till we get all the events, and if the progress pane is on, display the appropriate message there. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176214

Patch Set 1 #

Patch Set 2 : removed stray line in TimelineModel #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 3 chunks +17 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
caseq
6 years, 6 months ago (2014-06-11 15:30:03 UTC) #1
yurys
https://codereview.chromium.org/322403004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js File Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/322403004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode702 Source/devtools/front_end/timeline/TimelinePanel.js:702: this.toggleTimelineButton.title = WebInspector.UIString("Another profiler is already active"); Hm, why ...
6 years, 6 months ago (2014-06-16 07:18:08 UTC) #2
caseq
On 2014/06/16 07:18:08, yurys wrote: > https://codereview.chromium.org/322403004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js > File Source/devtools/front_end/timeline/TimelinePanel.js (right): > > https://codereview.chromium.org/322403004/diff/20001/Source/devtools/front_end/timeline/TimelinePanel.js#newcode702 > ...
6 years, 6 months ago (2014-06-16 08:39:30 UTC) #3
yurys
lgtm
6 years, 6 months ago (2014-06-16 09:47:18 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-16 14:09:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/322403004/20001
6 years, 6 months ago (2014-06-16 14:10:56 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 15:39:36 UTC) #7
Message was sent while issue was closed.
Change committed as 176214

Powered by Google App Engine
This is Rietveld 408576698