Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: build/android/pylib/gtest/setup.py

Issue 322403003: Pass GYP DEPTH variable to isolate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated build/android/pylib/gtest/setup.py and restored space for PRODUCT_DIR Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/gtest/setup.py
diff --git a/build/android/pylib/gtest/setup.py b/build/android/pylib/gtest/setup.py
index c691e412cbdb2e6e68d8e273a736fb799f2ef238..3787cfabf6b503843c02a64497754c57e09233af 100644
--- a/build/android/pylib/gtest/setup.py
+++ b/build/android/pylib/gtest/setup.py
@@ -131,6 +131,7 @@ def _GenerateDepsDirUsingIsolate(suite_name, isolate_file_path=None):
'--outdir', constants.ISOLATE_DEPS_DIR,
'--path-variable', 'PRODUCT_DIR', constants.GetOutDirectory(),
+ '--path-variable', 'DEPTH', constants.DIR_SOURCE_ROOT,
M-A Ruel 2014/06/11 18:21:22 please reverse the order so they are sorted.
kjellander_chromium 2014/06/11 18:33:30 Done.
'--config-variable', 'OS', 'android',
'--config-variable', 'chromeos', '0',
« no previous file with comments | « base/base_unittests.isolate ('k') | build/isolate.gypi » ('j') | build/isolate.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698