Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/isolate.gypi

Issue 322403003: Pass GYP DEPTH variable to isolate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed DEPTH use in include and renamed ROOT_DIR->DEPTH Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_unittests.isolate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index 6267441e7394d3da71597e081e225527d803c4be..7df2129f6537d8652b41658fd837a1ca45372293 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -82,7 +82,8 @@
# Path variables are used to replace file paths when loading a .isolate
# file
- '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
M-A Ruel 2014/06/11 18:03:02 No, for odd reasons relating to path escaping on W
kjellander_chromium 2014/06/11 18:15:06 Ah, Windows :) Do I need the same thing for DEPTH
M-A Ruel 2014/06/11 18:21:22 I think DEPTH will be fine. Let's try without firs
+ '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ '--path-variable', 'DEPTH', '<(DEPTH)',
# Extra variables are replaced on the 'command' entry and on paths in
# the .isolate file but are not considered relative paths.
« no previous file with comments | « base/base_unittests.isolate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698