Pass GYP DEPTH variable to isolate.

Pass GYP DEPTH variable to isolate.

This should make it possible to get rid of the ugly
relative paths in the isolate files.

I'm including an example for base_unittests.isolate for 
demonstrative purposes only. I can remove it (or convert all
.isolate files in Chromium) before landing.

BUG=343106
TEST=Successful compile+test on Linux using:
ninja -C out/Release base_unittests_run xdisplaycheck
tools/swarming_client/isolate.py run -s out/Release/base_unittests.isolated

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276671

[M-A Ruel, 2014-06-11 18:03:02]

You'll have to update build/android/pylib/gtest/setup.py too

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi
File build/isolate.gypi (left):

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi#oldco...
build/isolate.gypi:85: '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
No, for odd reasons relating to path escaping on Windows, you have to keep the
space.

[kjellander_chromium, 2014-06-11 18:15:06]

Updated build/android/pylib/gtest/setup.py and restored PRODUCT_DIR - do I need
the same space for DEPTH?

Should we remove base_unittests.isolate from this CL and group all the .isolate
files into a separate CL?

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi
File build/isolate.gypi (left):

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi#oldco...
build/isolate.gypi:85: '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
On 2014/06/11 18:03:02, M-A Ruel wrote:
> No, for odd reasons relating to path escaping on Windows, you have to keep the
> space.

Ah, Windows :)
Do I need the same thing for DEPTH then?

[M-A Ruel, 2014-06-11 18:21:23]

On 2014/06/11 18:15:06, kjellander wrote:
> Updated build/android/pylib/gtest/setup.py and restored PRODUCT_DIR - do I
need
> the same space for DEPTH?

No, since it is calling directly in python.

> Should we remove base_unittests.isolate from this CL and group all the
.isolate
> files into a separate CL?

No it's fine in the same CL.

lgtm

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi
File build/isolate.gypi (left):

https://codereview.chromium.org/322403003/diff/40001/build/isolate.gypi#oldco...
build/isolate.gypi:85: '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
On 2014/06/11 18:15:06, kjellander wrote:
> On 2014/06/11 18:03:02, M-A Ruel wrote:
> > No, for odd reasons relating to path escaping on Windows, you have to keep
the
> > space.
> 
> Ah, Windows :)
> Do I need the same thing for DEPTH then?

I think DEPTH will be fine. Let's try without first.

https://codereview.chromium.org/322403003/diff/60001/build/android/pylib/gtes...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/322403003/diff/60001/build/android/pylib/gtes...
build/android/pylib/gtest/setup.py:134: '--path-variable', 'DEPTH',
constants.DIR_SOURCE_ROOT,
please reverse the order so they are sorted.

https://codereview.chromium.org/322403003/diff/60001/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/322403003/diff/60001/build/isolate.gypi#newco...
build/isolate.gypi:86: '--path-variable', 'DEPTH', '<(DEPTH)',
same

[kjellander_chromium, 2014-06-11 18:33:30]

To clarify: do you want me to update all .isolate files below src/ and include
in this CL? I think it's not really necessary for files that only have one level
of parent-dir paths, like "../testing/test_env.py".

Do you think it's necessary. I'd vote for removing base_unittests.isolate from
this CL and only apply this for WebRTC for now (since we have cases of 5 levels
of ".." in our .isolate files)

https://codereview.chromium.org/322403003/diff/60001/build/android/pylib/gtes...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/322403003/diff/60001/build/android/pylib/gtes...
build/android/pylib/gtest/setup.py:134: '--path-variable', 'DEPTH',
constants.DIR_SOURCE_ROOT,
On 2014/06/11 18:21:22, M-A Ruel wrote:
> please reverse the order so they are sorted.

Done.

https://codereview.chromium.org/322403003/diff/60001/build/isolate.gypi
File build/isolate.gypi (right):

https://codereview.chromium.org/322403003/diff/60001/build/isolate.gypi#newco...
build/isolate.gypi:86: '--path-variable', 'DEPTH', '<(DEPTH)',
On 2014/06/11 18:21:23, M-A Ruel wrote:
> same

Done.

[kjellander_chromium, 2014-06-12 09:24:23]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2014-06-12 09:24:27]

The CQ bit was unchecked by kjellander@chromium.org

[kjellander_chromium, 2014-06-12 09:32:41]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-06-12 09:33:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kjellander@chromium.org/322403003/100001

[commit-bot: I haz the power, 2014-06-12 14:29:07]

Change committed as 276671