Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: Source/platform/heap/HeapTest.cpp

Issue 322343002: Oilpan: Fix ParamStorageTraits for RawPtr<T>. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/HeapTest.cpp
diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp
index 3a2fc82352eb5577309670aef54433018fc3fc6a..bb8e21c68cd50dd4047cb37ce1a931149647aec6 100644
--- a/Source/platform/heap/HeapTest.cpp
+++ b/Source/platform/heap/HeapTest.cpp
@@ -341,6 +341,7 @@ public:
bool operator==(const OffHeapInt& other) const { return other.value() == value(); }
unsigned hash() { return IntHash<int>::hash(m_x); }
+ void voidFunction() { }
protected:
OffHeapInt(int x) : m_x(x) { }
@@ -3989,6 +3990,8 @@ TEST(HeapTest, Bind)
Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
// The closure should have a persistent handle to the Bar.
EXPECT_EQ(2u, Bar::s_live);
+ // RawPtr<OffHeaInt> should not make Persistent.
Mads Ager (chromium) 2014/06/11 08:36:12 OffHeapInt
tkent 2014/06/11 08:39:47 Done.
+ Closure closure3 = bind(&OffHeapInt::voidFunction, RawPtr<OffHeapInt>(OffHeapInt::create(1).get()));
tkent 2014/06/11 08:12:17 This was not compilable without the Handle.h chang
UseMixin::s_traceCount = 0;
Mixin* mixin = UseMixin::create();
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698