Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 322343002: Oilpan: Fix ParamStorageTraits for RawPtr<T>. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Oilpan: Fix ParamStorageTraits for RawPtr<T>. RawPtr<> can be used for off-heap classes. e.g. RawPtrWillBeMember<OffHeap> So, we should check if T is on-heap for ParamStorageTraits<RawPtr<T>>. This CL also introduces IsGarbageCollectedType<T> struct to simplify on-heap class check. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175951

Patch Set 1 #

Total comments: 3

Patch Set 2 : p #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -36 lines) Patch
M Source/platform/heap/Handle.h View 2 chunks +36 lines, -36 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Please review this. https://codereview.chromium.org/322343002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/322343002/diff/1/Source/platform/heap/HeapTest.cpp#newcode3994 Source/platform/heap/HeapTest.cpp:3994: Closure closure3 = bind(&OffHeapInt::voidFunction, RawPtr<OffHeapInt>(OffHeapInt::create(1).get())); This ...
6 years, 6 months ago (2014-06-11 08:12:17 UTC) #1
Mads Ager (chromium)
LGTM The assumption that RawPtr<T> was only used for garbage collected types was spectacularly wrong. ...
6 years, 6 months ago (2014-06-11 08:36:12 UTC) #2
tkent
https://codereview.chromium.org/322343002/diff/1/Source/platform/heap/HeapTest.cpp File Source/platform/heap/HeapTest.cpp (right): https://codereview.chromium.org/322343002/diff/1/Source/platform/heap/HeapTest.cpp#newcode3993 Source/platform/heap/HeapTest.cpp:3993: // RawPtr<OffHeaInt> should not make Persistent. On 2014/06/11 08:36:12, ...
6 years, 6 months ago (2014-06-11 08:39:47 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-11 08:39:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/322343002/20001
6 years, 6 months ago (2014-06-11 08:40:34 UTC) #5
haraken
LGTM
6 years, 6 months ago (2014-06-11 08:58:10 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 09:47:44 UTC) #7
Message was sent while issue was closed.
Change committed as 175951

Powered by Google App Engine
This is Rietveld 408576698