Media Galleries: Fix PTP Devices on Windows

Media Galleries: Fix PTP Devices on Windows

PTP devices on Windows don't always provide ctime or mtime.

The Nikkon provides ctime only. The Sony provides neither. We shouldn't refuse to use these files just because they lack ctime/mtime.

BUG=381807
TEST=manually verified that this fixed the Nikkon and Sony test cameras on my Windows machine.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278318

[tommycli, 2014-06-17 23:47:30]

thestig: ptal

[Lei Zhang, 2014-06-18 00:54:26]

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
File chrome/browser/media_galleries/win/mtp_device_operations_util.cc (right):

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
chrome/browser/media_galleries/win/mtp_device_operations_util.cc:135: // Some
PTP devices don't provide an mtime. Try using the ctime instead.
s/an mtime/a mtime/

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
chrome/browser/media_galleries/win/mtp_device_operations_util.cc:238:
GetLastModifiedTime(properties_values.get(), last_modified_time);
This is the only caller. Just change the return type to void if you are not
going to check it?

[tommycli, 2014-06-18 16:28:50]

thestig: thx!

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
File chrome/browser/media_galleries/win/mtp_device_operations_util.cc (right):

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
chrome/browser/media_galleries/win/mtp_device_operations_util.cc:135: // Some
PTP devices don't provide an mtime. Try using the ctime instead.
On 2014/06/18 00:54:26, Lei Zhang wrote:
> s/an mtime/a mtime/

I think "an" for vowel sounds?

https://codereview.chromium.org/322333005/diff/1/chrome/browser/media_galleri...
chrome/browser/media_galleries/win/mtp_device_operations_util.cc:238:
GetLastModifiedTime(properties_values.get(), last_modified_time);
On 2014/06/18 00:54:26, Lei Zhang wrote:
> This is the only caller. Just change the return type to void if you are not
> going to check it?

Done. I also changed the method's flow a bit since we don't need to return
anything.

[Lei Zhang, 2014-06-18 17:07:06]

lgtm

[tommycli, 2014-06-18 17:20:20]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-06-18 17:20:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tommycli@chromium.org/322333005/20001

[tommycli, 2014-06-18 22:29:36]

On 2014/06/18 17:20:58, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/tommycli@chromium.org/322333005/20001

Can confirm it worked with PTP:

Canon camera, nexus 4, nexus 7

[commit-bot: I haz the power, 2014-06-19 11:13:26]

Change committed as 278318