Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: sync/internal_api/public/base/invalidation.h

Issue 322333004: sync: Inject sync/'s dependency on invalidations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/sync_scheduler_unittest.cc ('k') | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base/invalidation.h
diff --git a/sync/internal_api/public/base/invalidation.h b/sync/internal_api/public/base/invalidation.h
index cf26112e2244839b056c5fa0906b45cb46afe58d..309eb7de0147355fb481d350119dd86b508b90fb 100644
--- a/sync/internal_api/public/base/invalidation.h
+++ b/sync/internal_api/public/base/invalidation.h
@@ -35,6 +35,7 @@ class SYNC_EXPORT Invalidation {
static scoped_ptr<Invalidation> InitFromValue(
const base::DictionaryValue& value);
+ Invalidation(const Invalidation& other);
~Invalidation();
// Compares two invalidations. The comparison ignores ack-tracking state.
@@ -84,12 +85,9 @@ class SYNC_EXPORT Invalidation {
// invalidations in order to allow the ack tracker to drop the invalidation,
// too.
//
- // The drop record will be tracked by the specified
- // DroppedInvalidationTracker. The caller should hang on to this tracker. It
- // will need to use it when it recovers from this drop event, or if it needs
- // to record another drop event for the same ObjectID. Refer to the
- // documentation of DroppedInvalidationTracker for more details.
- void Drop(DroppedInvalidationTracker* tracker) const;
+ // To indicate recovery from a drop event, the client should call
+ // Acknowledge() on the most recently dropped inavlidation.
+ void Drop();
scoped_ptr<base::DictionaryValue> ToValue() const;
std::string ToString() const;
« no previous file with comments | « sync/engine/sync_scheduler_unittest.cc ('k') | sync/internal_api/public/base/invalidation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698