Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 322333004: sync: Inject sync/'s dependency on invalidations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing files Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index a5f2de070f39214d01f033f47b6719e88d6f200a..07de26f26fc68ad3a7074028528022b0ce8d0874 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -20,6 +20,7 @@
#include "sync/engine/syncer_types.h"
#include "sync/internal_api/change_reorder_buffer.h"
#include "sync/internal_api/public/base/cancelation_signal.h"
+#include "sync/internal_api/public/base/invalidation_interface.h"
#include "sync/internal_api/public/base/model_type.h"
#include "sync/internal_api/public/base_node.h"
#include "sync/internal_api/public/configure_reason.h"
@@ -974,30 +975,17 @@ void SyncManagerImpl::OnInvalidatorStateChange(InvalidatorState state) {
}
void SyncManagerImpl::OnIncomingInvalidation(
- const ObjectIdInvalidationMap& invalidation_map) {
+ syncer::ModelType type,
+ scoped_ptr<InvalidationInterface> invalidation) {
DCHECK(thread_checker_.CalledOnValidThread());
- // We should never receive IDs from non-sync objects.
- ObjectIdSet ids = invalidation_map.GetObjectIds();
- for (ObjectIdSet::const_iterator it = ids.begin(); it != ids.end(); ++it) {
- ModelType type;
- if (!ObjectIdToRealModelType(*it, &type)) {
- DLOG(WARNING) << "Notification has invalid id: " << ObjectIdToString(*it);
- }
- }
-
- if (invalidation_map.Empty()) {
- LOG(WARNING) << "Sync received invalidation without any type information.";
- } else {
- scheduler_->ScheduleInvalidationNudge(
- TimeDelta::FromMilliseconds(kSyncSchedulerDelayMsec),
- invalidation_map, FROM_HERE);
- debug_info_event_listener_.OnIncomingNotification(invalidation_map);
- }
+ scheduler_->ScheduleInvalidationNudge(
+ TimeDelta::FromMilliseconds(kSyncSchedulerDelayMsec),
+ type,
+ invalidation.Pass(),
+ FROM_HERE);
}
-std::string SyncManagerImpl::GetOwnerName() const { return "SyncManagerImpl"; }
-
void SyncManagerImpl::RefreshTypes(ModelTypeSet types) {
DCHECK(thread_checker_.CalledOnValidThread());
if (types.Empty()) {

Powered by Google App Engine
This is Rietveld 408576698