sync: Inject sync/'s dependency on invalidations

chrome/browser/sync/glue/invalidation_wrapper.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_GLUE_INVALIDATION_WRAPPER_H_
+#define CHROME_BROWSER_SYNC_GLUE_INVALIDATION_WRAPPER_H_
+
+#include "sync/internal_api/public/base/invalidation.h"
+#include "sync/internal_api/public/base/invalidation_interface.h"
+
+namespace browser_sync {
+
+// Wraps a syncer::Invalidation in the syncer::InvalidationInterface.
+class InvalidationWrapper : public syncer::InvalidationInterface {

[tim (not reviewing), 2014/06/18 22:41:11]

s/Wrapper/Adapter.

But, could components/invalidator/Invalidation.h not implement
InvalidationInterface directly, and avoid the extra adapter?

[rlarocque, 2014/06/19 00:50:19]

Will do.
If we did that, then components/invalidator/ would have to depend on
chrome/browser/sync/ (definitely wrong) or sync/ (which is one of the things I'd
like to fix as part of crbug.com/259559).

[rlarocque, 2014/06/20 20:00:12]

Done.

+ public:
+  explicit InvalidationWrapper(const syncer::Invalidation& invalidation);
+  virtual ~InvalidationWrapper();
+
+  // Implementation of InvalidationInterface.
+  virtual bool IsUnknownVersion() const OVERRIDE;
+  virtual const std::string& GetPayload() const OVERRIDE;
+  virtual int64 GetVersion() const OVERRIDE;
+  virtual void Acknowledge() OVERRIDE;
+  virtual void Drop() OVERRIDE;
+
+ private:
+  syncer::Invalidation invalidation_;
+};
+
+}  // namespace browser_sync
+
+#endif  // CHROME_BROWSER_SYNC_GLUE_INVALIDATION_WRAPPER_H_