Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 322333003: Set default config values in quic_client_bin (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc
Project:
chromium
Visibility:
Public.

Description

Set default config values in quic_client_bin Merge internal change: 69295877 R=rch@chromium.org, rjshade@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-17 21:37:47 UTC) #1
Robbie Shade
lgtm
6 years, 6 months ago (2014-06-17 21:58:11 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-17 22:28:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/322333003/1
6 years, 6 months ago (2014-06-17 22:30:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 22:30:04 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 22:30:05 UTC) #6
ramant (doing other things)
On 2014/06/17 22:30:05, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 6 months ago (2014-06-18 16:57:52 UTC) #7
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-18 18:09:52 UTC) #8
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-18 18:47:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/322333003/1
6 years, 6 months ago (2014-06-18 18:49:11 UTC) #10
commit-bot: I haz the power
Change committed as 278316
6 years, 6 months ago (2014-06-19 11:07:14 UTC) #11
wtc
6 years, 6 months ago (2014-06-19 20:06:42 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698