Only allow ShowAppInfoFlow on Ash and Views platforms

Only allow ShowAppInfoFlow on Ash and Views platforms

Only allows ShowAppInfoFlow (and hence the app info dialog) to be
enabled on Ash and Views platforms (everything but Mac OS X for now).

This will not display the item in the context menu either.

BUG=382371
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276646

[tapted, 2014-06-11 07:06:17]

https://codereview.chromium.org/322323002/diff/1/chrome/browser/ui/ash/app_li...
File chrome/browser/ui/ash/app_list/app_list_controller_ash.cc (right):

https://codereview.chromium.org/322323002/diff/1/chrome/browser/ui/ash/app_li...
chrome/browser/ui/ash/app_list/app_list_controller_ash.cc:10: #include
"ui/app_list/app_list_switches.h"
Since mac/cocoa is the oddball, I think it would be nicer to just modify a
single file, rather than adding multiple new callsites for IsAppInfoEnabled();

Most consistent with existing flags I think would just be to edit
app_list_switches.cc and change 

bool IsAppInfoEnabled()

into 

bool IsAppInfoEnabled() {
#if defined(TOOLKIT_VIEWS)
  return !CommandLine::ForCurrentProcess()->HasSwitch(kDisableAppInfo);
#else
  return false;
#endif
}



alternative: you could a subclass of AppListControllerDelegateImpl in the
anonymous namespace in app_list_service_mac.mm which overrides it for Mac to
just return false. But that's more complicated and I can't think of a real
benefit to it.

[sashab, 2014-06-11 07:10:50]

Thanks :) Now you're an OWNER too, so please review :)

https://codereview.chromium.org/322323002/diff/1/chrome/browser/ui/ash/app_li...
File chrome/browser/ui/ash/app_list/app_list_controller_ash.cc (right):

https://codereview.chromium.org/322323002/diff/1/chrome/browser/ui/ash/app_li...
chrome/browser/ui/ash/app_list/app_list_controller_ash.cc:10: #include
"ui/app_list/app_list_switches.h"
On 2014/06/11 07:06:17, tapted wrote:
> Since mac/cocoa is the oddball, I think it would be nicer to just modify a
> single file, rather than adding multiple new callsites for IsAppInfoEnabled();
> 
> Most consistent with existing flags I think would just be to edit
> app_list_switches.cc and change 
> 
> bool IsAppInfoEnabled()
> 
> into 
> 
> bool IsAppInfoEnabled() {
> #if defined(TOOLKIT_VIEWS)
>   return !CommandLine::ForCurrentProcess()->HasSwitch(kDisableAppInfo);
> #else
>   return false;
> #endif
> }
> 
> 
> 
> alternative: you could a subclass of AppListControllerDelegateImpl in the
> anonymous namespace in app_list_service_mac.mm which overrides it for Mac to
> just return false. But that's more complicated and I can't think of a real
> benefit to it.

Good suggestion :) Thanks.

[tapted, 2014-06-11 08:12:45]

lgtm

[sashab, 2014-06-11 22:37:09]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:39:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/322323002/30007

[commit-bot: I haz the power, 2014-06-11 23:55:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15733)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18865)

[commit-bot: I haz the power, 2014-06-12 00:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:07:18]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[sashab, 2014-06-12 03:45:43]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-06-12 03:50:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/322323002/30007

[commit-bot: I haz the power, 2014-06-12 12:55:24]

Change committed as 276646