Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 322293004: Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts. (Closed)

Created:
6 years, 6 months ago by r.kasibhatla
Modified:
6 years, 3 months ago
Reviewers:
navabi1, dpranke, navabi, tonyg, marja
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts. Removing the instances of ChromiumTestShell after buildbot change https://crrev.com/302743002/ has landed. Adding ChromeShell was already done as part https://codereview.chromium.org/302653004/. BUG=None R=tonyg,marja,navabi,dpranke Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M tools/telemetry/docs/telemetry.core.browser_finder.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (1 generated)
r.kasibhatla
PTAL.
6 years, 6 months ago (2014-06-11 11:49:08 UTC) #1
marja
lgtm
6 years, 6 months ago (2014-06-11 13:16:08 UTC) #2
tonyg
lgtm I just double checked that the chromium.perf bots are passing --browser=android-chrome-shell. So if the ...
6 years, 6 months ago (2014-06-11 15:15:49 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-11 15:15:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/322293004/1
6 years, 6 months ago (2014-06-11 15:17:12 UTC) #5
navabi
lgtm
6 years, 6 months ago (2014-06-11 19:35:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:00:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:31:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19591)
6 years, 6 months ago (2014-06-11 21:31:13 UTC) #9
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-11 22:49:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/322293004/1
6 years, 6 months ago (2014-06-11 22:51:18 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:55:27 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:58:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19815)
6 years, 6 months ago (2014-06-11 22:58:01 UTC) #14
r.kasibhatla
The CQ bit was checked by r.kasibhatla@samsung.com
6 years, 6 months ago (2014-06-12 03:20:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/322293004/1
6 years, 6 months ago (2014-06-12 03:21:32 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 11:22:21 UTC) #17
Message was sent while issue was closed.
Change committed as 276628

Powered by Google App Engine
This is Rietveld 408576698