Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 322273003: MSE: On init segment received, set need random access point flag on all track buffers (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

MSE: On init segment received, set need random access point flag on all track buffers This change updates Chromium to observe the proposed text in the W3C MSE spec per https://www.w3.org/Bugs/Public/show_bug.cgi?id=26032. Previously, SourceBufferStream::Append() would fail and report decode error if the first processed (and appended to SBS) frame(s) after a non-first init segment were not random access points. This change drops those frames by setting the 'need random access point flag' on all track buffers true during the initialization segment received algorithm in SourceState::OnNewConfigs(). R=acolwell@chromium.org TEST=shiny new test that fails (on both Legacy and new FrameProcessors) without the rest of this change applied Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -10 lines) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M media/filters/frame_processor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/filters/frame_processor.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M media/filters/frame_processor_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/frame_processor_base.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
wolenetz
PTAL @ PS1 This CL is rebased on https://codereview.chromium.org/324243002/ (and ideally needs that CL to ...
6 years, 6 months ago (2014-06-11 00:59:41 UTC) #1
wolenetz
On 2014/06/11 00:59:41, wolenetz wrote: > PTAL @ PS1 > This CL is rebased on ...
6 years, 6 months ago (2014-06-11 02:01:52 UTC) #2
wolenetz
On 2014/06/11 02:01:52, wolenetz wrote: > On 2014/06/11 00:59:41, wolenetz wrote: > > PTAL @ ...
6 years, 6 months ago (2014-06-11 16:59:20 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-11 22:15:38 UTC) #4
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-11 22:24:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/322273003/1
6 years, 6 months ago (2014-06-11 22:25:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:44:11 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:10:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38159)
6 years, 6 months ago (2014-06-12 00:10:28 UTC) #9
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-12 19:24:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/322273003/1
6 years, 6 months ago (2014-06-12 19:33:04 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 03:58:10 UTC) #12
Message was sent while issue was closed.
Change committed as 276914

Powered by Google App Engine
This is Rietveld 408576698