Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 322273002: First step in cleaning up pefile hack. (Closed)

Created:
6 years, 6 months ago by szager1
Modified:
6 years, 6 months ago
Reviewers:
Vadim Sh., Michael Moss
CC:
chromium-reviews, cmp-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M deps2git.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
szager1
6 years, 6 months ago (2014-06-11 02:02:03 UTC) #1
Michael Moss
lgtm
6 years, 6 months ago (2014-06-11 15:19:47 UTC) #2
szager1
The CQ bit was checked by szager@chromium.org
6 years, 6 months ago (2014-06-11 17:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/322273002/20001
6 years, 6 months ago (2014-06-11 17:28:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 17:28:09 UTC) #5
commit-bot: I haz the power
Failed to apply patch for deps2git/deps2git.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-11 17:28:10 UTC) #6
szager1
The CQ bit was checked by szager@chromium.org
6 years, 6 months ago (2014-06-11 17:37:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/322273002/60001
6 years, 6 months ago (2014-06-11 17:38:21 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:38:58 UTC) #9
Message was sent while issue was closed.
Change committed as 276439

Powered by Google App Engine
This is Rietveld 408576698